linux-kernel - Re: [PATCH v4 1/5] printk: nbcon: Export console_is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250917-imaginary-vigorous-condor-fccdc1@lemur>
Date: Wed, 17 Sep 2025 10:07:47 -0400
From: Konstantin Ryabitsev <konstantin@...uxfoundation.org>
To: Marcos Paulo de Souza <mpdesouza@...e.com>
Cc: Petr Mladek <pmladek@...e.com>, 
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Steven Rostedt <rostedt@...dmis.org>, 
	John Ogness <john.ogness@...utronix.de>, Sergey Senozhatsky <senozhatsky@...omium.org>, 
	Jason Wessel <jason.wessel@...driver.com>, Daniel Thompson <danielt@...nel.org>, 
	Douglas Anderson <dianders@...omium.org>, linux-kernel@...r.kernel.org, 
	kgdb-bugreport@...ts.sourceforge.net
Subject: Re: [PATCH v4 1/5] printk: nbcon: Export console_is_usable

On Wed, Sep 17, 2025 at 09:21:48AM -0300, Marcos Paulo de Souza wrote:
> > Signed-off-by: Marcos Paulo de Souza <mpdesouza@...e.com>
> > Reviewed-by: Petr Mladek <pmladek@...e.com>
> > 
> > It means that Macros developed a patch and Petr reviewed it.
> > The patch was not longer modified.

That's not entirely correct. The signed-off trailer is used as the boundary
indicating who was the person responsible for collecting the trailers. When
the trailers are collected by the original author as part of their iteration
cycles, their signed-off-by trailer goes below any trailers they have
received.

When the trailers are collected by the maintainer, any trailers they retrieve
will go below the original author's S-o-b, but above their own.

> > 
> > Note the Reviewed-by tag might be preserved even when Marcos
> > later did some cosmetic changes, e.g. fixed a typo, formatting,
> > or rebased.
> 
> Got it. I used b4 prep --update-trailers, and it added the Reviewed-by
> before my Sign-off. But still, this patch didn't change since the last
> submission, so I thought that it would be ok.

That is the correct behaviour.

-K