linux-kernel - Re: [PATCH v1] clk: keystone: sci-clk: use devm_kmemdup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250917143022.vqp77wmu47yumwh2@revenge>
Date: Wed, 17 Sep 2025 09:30:22 -0500
From: Nishanth Menon <nm@...com>
To: Raag Jadav <raag.jadav@...el.com>
CC: <kristo@...nel.org>, <ssantosh@...nel.org>, <mturquette@...libre.com>,
        <sboyd@...nel.org>, <linux-kernel@...r.kernel.org>,
        <linux-clk@...r.kernel.org>, <andriy.shevchenko@...ux.intel.com>
Subject: Re: [PATCH v1] clk: keystone: sci-clk: use devm_kmemdup_array()

On 18:15-20250916, Raag Jadav wrote:
> Convert to use devm_kmemdup_array() which is more robust.
> 
> Signed-off-by: Raag Jadav <raag.jadav@...el.com>
> ---
>  drivers/clk/keystone/sci-clk.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/clk/keystone/sci-clk.c b/drivers/clk/keystone/sci-clk.c
> index c5894fc9395e..a4b42811de55 100644
> --- a/drivers/clk/keystone/sci-clk.c
> +++ b/drivers/clk/keystone/sci-clk.c
> @@ -480,13 +480,10 @@ static int ti_sci_scan_clocks_from_fw(struct sci_clk_provider *provider)
>  		num_clks++;
>  	}
>  
> -	provider->clocks = devm_kmalloc_array(dev, num_clks, sizeof(sci_clk),
> -					      GFP_KERNEL);
> +	provider->clocks = devm_kmemdup_array(dev, clks, num_clks, sizeof(sci_clk), GFP_KERNEL);
>  	if (!provider->clocks)
>  		return -ENOMEM;
>  
> -	memcpy(provider->clocks, clks, num_clks * sizeof(sci_clk));
> -
>  	provider->num_clocks = num_clks;
>  
>  	devm_kfree(dev, clks);
> -- 
> 2.34.1
> 

Reviewed-by: Nishanth Menon <nm@...com>

Also ran a basic boot tests on K3 devices i have access to.. so all
good.
-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D
https://ti.com/opensource