linux-kernel - Re: [PATCH 1/2] dt-bindings: iio: temperature: add support for EMC1812

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <175811949688.2007543.2579513958253379108.robh@kernel.org>
Date: Wed, 17 Sep 2025 09:31:36 -0500
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Marius Cristea <marius.cristea@...rochip.com>
Cc: Nuno Sá <nuno.sa@...log.com>, 
 linux-kernel@...r.kernel.org, Jonathan Cameron <jic23@...nel.org>, 
 Andy Shevchenko <andy@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
 devicetree@...r.kernel.org, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
 linux-iio@...r.kernel.org, David Lechner <dlechner@...libre.com>
Subject: Re: [PATCH 1/2] dt-bindings: iio: temperature: add support for
 EMC1812


On Wed, 17 Sep 2025 15:21:57 +0300, Marius Cristea wrote:
> This is the devicetree schema for Microchip EMC1812/13/14/15/33
> Multichannel Low-Voltage Remote Diode Sensor Family.
> 
> Signed-off-by: Marius Cristea <marius.cristea@...rochip.com>
> ---
>  .../iio/temperature/microchip,emc1812.yaml         | 223 +++++++++++++++++++++
>  MAINTAINERS                                        |   6 +
>  2 files changed, 229 insertions(+)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/temperature/microchip,emc1812.yaml: allOf:1:then:patternProperties: '^channel@1$' should not be valid under {'pattern': '^\\^[a-zA-Z0-9,\\-._#@]+\\$$'}
	hint: Fixed strings belong in 'properties', not 'patternProperties'
	from schema $id: http://devicetree.org/meta-schemas/keywords.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/temperature/microchip,emc1812.yaml: allOf:3:then:patternProperties: '^channel@4$' should not be valid under {'pattern': '^\\^[a-zA-Z0-9,\\-._#@]+\\$$'}
	hint: Fixed strings belong in 'properties', not 'patternProperties'
	from schema $id: http://devicetree.org/meta-schemas/keywords.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/temperature/microchip,emc1812.example.dtb: temperature-sensor@4c (microchip,emc1813): channel@2:reg:0:0: 2 is greater than the maximum of 1
	from schema $id: http://devicetree.org/schemas/iio/temperature/microchip,emc1812.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250917-iio-emc1812-v1-1-0b1f74cea7ab@microchip.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.