linux-kernel - Re: [PATCH] pds_fwctl: Replace kzalloc + copy_from_user with memdup_user in pdsfc_fw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250917151229.GG1326709@ziepe.ca>
Date: Wed, 17 Sep 2025 12:12:29 -0300
From: Jason Gunthorpe <jgg@...pe.ca>
To: Thorsten Blum <thorsten.blum@...ux.dev>
Cc: Brett Creeley <brett.creeley@....com>,
	Dave Jiang <dave.jiang@...el.com>,
	Saeed Mahameed <saeedm@...dia.com>,
	Jonathan Cameron <Jonathan.Cameron@...wei.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pds_fwctl: Replace kzalloc + copy_from_user with
 memdup_user in pdsfc_fw_rpc

On Wed, Sep 17, 2025 at 05:09:41PM +0200, Thorsten Blum wrote:
> Replace kzalloc() followed by copy_from_user() with memdup_user() to
> improve and simplify pdsfc_fw_rpc().
> 
> Return early if an error occurs and remove the obsolete 'err_out' label.
> 
> No functional changes intended.
> 
> Signed-off-by: Thorsten Blum <thorsten.blum@...ux.dev>
> ---
>  drivers/fwctl/pds/main.c | 16 ++++------------
>  1 file changed, 4 insertions(+), 12 deletions(-)

Looks OK to me

Reviewed-by: Jason Gunthorpe <jgg@...dia.com>

Jason