linux-kernel - Re: [PATCH] clocksource/drivers/timer-tegra186: don't print superfluous errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <12921334.O9o76ZdvQC@senjougahara>
Date: Wed, 17 Sep 2025 11:05:49 +0900
From: Mikko Perttunen <mperttunen@...dia.com>
To: linux-kernel@...r.kernel.org,
 Wolfram Sang <wsa+renesas@...g-engineering.com>
Cc: Wolfram Sang <wsa+renesas@...g-engineering.com>,
 Daniel Lezcano <daniel.lezcano@...aro.org>,
 Thomas Gleixner <tglx@...utronix.de>,
 Thierry Reding <thierry.reding@...il.com>,
 Jonathan Hunter <jonathanh@...dia.com>, linux-tegra@...r.kernel.org
Subject:
 Re: [PATCH] clocksource/drivers/timer-tegra186: don't print superfluous
 errors

On Thursday, August 14, 2025 4:06 AM Wolfram Sang wrote:
> The watchdog core will handle error messages already.
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@...g-engineering.com>
> ---
>  drivers/clocksource/timer-tegra186.c | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/clocksource/timer-tegra186.c b/drivers/clocksource/timer-tegra186.c
> index e5394f98a02e..b40d7ed37936 100644
> --- a/drivers/clocksource/timer-tegra186.c
> +++ b/drivers/clocksource/timer-tegra186.c
> @@ -328,16 +328,12 @@ static struct tegra186_wdt *tegra186_wdt_create(struct tegra186_timer *tegra,
>  	wdt->base.parent = tegra->dev;
>  
>  	err = watchdog_init_timeout(&wdt->base, 5, tegra->dev);
> -	if (err < 0) {
> -		dev_err(tegra->dev, "failed to initialize timeout: %d\n", err);
> +	if (err < 0)
>  		return ERR_PTR(err);
> -	}
>  
>  	err = devm_watchdog_register_device(tegra->dev, &wdt->base);
> -	if (err < 0) {
> -		dev_err(tegra->dev, "failed to register WDT: %d\n", err);
> +	if (err < 0)
>  		return ERR_PTR(err);
> -	}
>  
>  	return wdt;
>  }
> 

Reviewed-by: Mikko Perttunen <mperttunen@...dia.com>