linux-kernel - Re: [PATCH v3 08/32] clk: at91: clk-master: use clk_parent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d2c1d736-689b-452d-8031-2cf76288dca1@tuxon.dev>
Date: Wed, 17 Sep 2025 09:49:55 +0300
From: Claudiu Beznea <claudiu.beznea@...on.dev>
To: Ryan Wanner <ryan.wanner@...rochip.com>, mturquette@...libre.com,
 sboyd@...nel.org, nicolas.ferre@...rochip.com, alexandre.belloni@...tlin.com
Cc: varshini.rajendran@...rochip.com, linux-clk@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
 robh@...nel.org
Subject: Re: [PATCH v3 08/32] clk: at91: clk-master: use clk_parent_data



On 9/16/25 20:35, Ryan Wanner wrote:
>>>       td_slck_hw = __clk_get_hw(of_clk_get_by_name(np, "td_slck"));
>>> -     md_slck_hw = __clk_get_hw(of_clk_get_by_name(np, "md_slck"));
>>> +     md_slck_hw = __clk_get_hw(of_clk_get_by_name(np, md_slck_name));
>> Please use:
>>
>> i = of_property_match_string(np, "clock-names", "md_slck");
>> if (i < 0)
>>     return;
>>
>> md_slck_name = of_clk_get_parent_name(np, i);
>>
>> Same sama7d65, sama7g5.
> For these SoCs the clk_hw struct is still needed since it is used later
> in the driver and not changed until a subsquent patch later in this
> series. Would it be better to hold this change untill then?

OK for me!

Thank you,
Claudiu