linux-kernel - RE: [PATCH v8 1/6] dt-bindings: phy: samsung,usb3-drd-phy: add ExynosAutov920 HS phy compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <054e01dc27a1$c2011120$46033360$@samsung.com>
Date: Wed, 17 Sep 2025 12:37:36 +0530
From: "Pritam Manohar Sutar" <pritam.sutar@...sung.com>
To: "'Krzysztof Kozlowski'" <krzk@...nel.org>
Cc: <vkoul@...nel.org>, <kishon@...nel.org>, <robh@...nel.org>,
	<krzk+dt@...nel.org>, <conor+dt@...nel.org>, <alim.akhtar@...sung.com>,
	<andre.draszik@...aro.org>, <peter.griffin@...aro.org>,
	<kauschluss@...root.org>, <ivo.ivanov.ivanov1@...il.com>,
	<igor.belwon@...tallysanemainliners.org>, <m.szyprowski@...sung.com>,
	<s.nawrocki@...sung.com>, <linux-phy@...ts.infradead.org>,
	<devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>, <linux-samsung-soc@...r.kernel.org>,
	<rosa.pila@...sung.com>, <dev.tailor@...sung.com>, <faraz.ata@...sung.com>,
	<muhammed.ali@...sung.com>, <selvarasu.g@...sung.com>
Subject: RE: [PATCH v8 1/6] dt-bindings: phy: samsung,usb3-drd-phy: add
 ExynosAutov920 HS phy compatible

Hi Krzysztof,


> -----Original Message-----
> From: Pritam Manohar Sutar <pritam.sutar@...sung.com>
> Sent: 04 September 2025 03:52 PM
> To: 'Krzysztof Kozlowski' <krzk@...nel.org>
> Cc: 'vkoul@...nel.org' <vkoul@...nel.org>; 'kishon@...nel.org'
> <kishon@...nel.org>; 'robh@...nel.org' <robh@...nel.org>;
> 'krzk+dt@...nel.org' <krzk+dt@...nel.org>; 'conor+dt@...nel.org'
> <conor+dt@...nel.org>; 'alim.akhtar@...sung.com'
> <alim.akhtar@...sung.com>; 'andre.draszik@...aro.org'
> <andre.draszik@...aro.org>; 'peter.griffin@...aro.org'
> <peter.griffin@...aro.org>; 'kauschluss@...root.org' <kauschluss@...root.org>;
> 'ivo.ivanov.ivanov1@...il.com' <ivo.ivanov.ivanov1@...il.com>;
> 'igor.belwon@...tallysanemainliners.org'
> <igor.belwon@...tallysanemainliners.org>; 'm.szyprowski@...sung.com'
> <m.szyprowski@...sung.com>; 's.nawrocki@...sung.com'
> <s.nawrocki@...sung.com>; 'linux-phy@...ts.infradead.org' <linux-
> phy@...ts.infradead.org>; 'devicetree@...r.kernel.org'
> <devicetree@...r.kernel.org>; 'linux-kernel@...r.kernel.org' <linux-
> kernel@...r.kernel.org>; 'linux-arm-kernel@...ts.infradead.org' <linux-arm-
> kernel@...ts.infradead.org>; 'linux-samsung-soc@...r.kernel.org' <linux-
> samsung-soc@...r.kernel.org>; 'rosa.pila@...sung.com'
> <rosa.pila@...sung.com>; 'dev.tailor@...sung.com'
> <dev.tailor@...sung.com>; 'faraz.ata@...sung.com'
> <faraz.ata@...sung.com>; 'muhammed.ali@...sung.com'
> <muhammed.ali@...sung.com>; 'selvarasu.g@...sung.com'
> <selvarasu.g@...sung.com>
> Subject: RE: [PATCH v8 1/6] dt-bindings: phy: samsung,usb3-drd-phy: add
> ExynosAutov920 HS phy compatible
> 
> Hi Krzysztof,
> 
> > -----Original Message-----
> > From: Krzysztof Kozlowski <krzk@...nel.org>
> > Sent: 04 September 2025 03:12 PM
> > To: Pritam Manohar Sutar <pritam.sutar@...sung.com>
> > Cc: vkoul@...nel.org; kishon@...nel.org; robh@...nel.org;
> > krzk+dt@...nel.org; conor+dt@...nel.org; alim.akhtar@...sung.com;
> > andre.draszik@...aro.org; peter.griffin@...aro.org;
> > kauschluss@...root.org; ivo.ivanov.ivanov1@...il.com;
> > igor.belwon@...tallysanemainliners.org;
> > m.szyprowski@...sung.com; s.nawrocki@...sung.com; linux-
> > phy@...ts.infradead.org; devicetree@...r.kernel.org; linux-
> > kernel@...r.kernel.org; linux-arm-kernel@...ts.infradead.org;
> > linux-samsung- soc@...r.kernel.org; rosa.pila@...sung.com;
> > dev.tailor@...sung.com; faraz.ata@...sung.com;
> > muhammed.ali@...sung.com; selvarasu.g@...sung.com
> > Subject: Re: [PATCH v8 1/6] dt-bindings: phy: samsung,usb3-drd-phy:
> > add
> > ExynosAutov920 HS phy compatible
> >
> > On 04/09/2025 09:51, Pritam Manohar Sutar wrote:
> > > Hi Krzysztof,
> > >
> > >> -----Original Message-----
> > >> From: Krzysztof Kozlowski <krzk@...nel.org>
> > >> Sent: 04 September 2025 12:18 PM
> > >> To: Pritam Manohar Sutar <pritam.sutar@...sung.com>
> > >> Cc: vkoul@...nel.org; kishon@...nel.org; robh@...nel.org;
> > >> krzk+dt@...nel.org; conor+dt@...nel.org; alim.akhtar@...sung.com;
> > >> andre.draszik@...aro.org; peter.griffin@...aro.org;
> > >> kauschluss@...root.org; ivo.ivanov.ivanov1@...il.com;
> > >> igor.belwon@...tallysanemainliners.org;
> > >> m.szyprowski@...sung.com; s.nawrocki@...sung.com; linux-
> > >> phy@...ts.infradead.org; devicetree@...r.kernel.org; linux-
> > >> kernel@...r.kernel.org; linux-arm-kernel@...ts.infradead.org;
> > >> linux-samsung- soc@...r.kernel.org; rosa.pila@...sung.com;
> > >> dev.tailor@...sung.com; faraz.ata@...sung.com;
> > >> muhammed.ali@...sung.com; selvarasu.g@...sung.com
> > >> Subject: Re: [PATCH v8 1/6] dt-bindings: phy: samsung,usb3-drd-phy:
> > >> add
> > >> ExynosAutov920 HS phy compatible
> > >>
> > >> On Wed, Sep 03, 2025 at 01:08:22PM +0530, Pritam Manohar Sutar wrote:
> > >>> Document support for the USB20 phy found on the ExynosAutov920 SoC.
> > >>> The
> > >>> USB20 phy is functionally identical to that on the Exynos850 SoC,
> > >>> so no driver changes are needed to support this phy. However, add
> > >>> a dedicated compatible string for USB20 phy found in this SoC.
> > >>>
> > >>> Signed-off-by: Pritam Manohar Sutar <pritam.sutar@...sung.com>
> > >>
> > >> You just dropped all tags without explaining why.
> > >
> > > Regretted inconvenience.
> > >
> > > There were significant changes in supplies' names in driver and
> > > schemas (patch-set v8). This led to make changes in patch no 5.  And
> > > review for these changes is needed.  Hence, removed RB tag in this patch-
> set.
> > >
> > > There was a ask for the same https://lore.kernel.org/linux-
> >
> phy/000401dc18cd$ec02a1b0$c407e510$@...sung.com/#:~:text=Let%20me%
> >
> 20know%2C%20because%20of%20above%20changes%2C%20should%20be%20
> >
> removing%20your%20%0A%27reviewed%2Dby%27%20tag%20from%20patch%
> > 201%20and%203.
> > >
> >
> >
> > Where in the changelog you explained why you dropped the tags?
> 
> Along with supplies' names, there were similar commit messages for patch no 1,
> 3 as patch no 5 (v7). (though, they were explaining schema more than h/w).
> Changed commit messages of the patch no 1, 3, 5 (v7) as per reference commits
> and would like to get them reviewed again, so did not add RB for patch 1 and 3,
> which you had given RB (in v7).
> 
> Forgot to add these details for dropping the RB tags in changelog.
> Do I need to send v9 by retaining RB for patch 1 and 3?
> 

Gentle Reminder. 

> >
> > Best regards,
> > Krzysztof
> 
> 
> Thank you.
> 
> Regards,
> Pritam

Thank you,

Regards,
Pritam