linux-kernel - Re: [PATCH v2 2/9] dt-bindings: fsl,fpga-qixis-i2c: extend support to also cover the LX2160ARDB FPGA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <hioigg5kn4lf2rvmfdxahxsuxhe4unvdkaoy5esoxepgc4jf7f@2wg42pxz3iry>
Date: Wed, 17 Sep 2025 10:15:55 +0300
From: Ioana Ciornei <ioana.ciornei@....com>
To: Frank Li <Frank.li@....com>
Cc: Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Linus Walleij <linus.walleij@...aro.org>, Bartosz Golaszewski <brgl@...ev.pl>, 
	Shawn Guo <shawnguo@...nel.org>, Michael Walle <mwalle@...nel.org>, Lee Jones <lee@...nel.org>, 
	devicetree@...r.kernel.org, linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/9] dt-bindings: fsl,fpga-qixis-i2c: extend support
 to also cover the LX2160ARDB FPGA

On Tue, Sep 16, 2025 at 12:18:10PM -0400, Frank Li wrote:
> On Mon, Sep 15, 2025 at 03:23:47PM +0300, Ioana Ciornei wrote:
> 
> subject:
> dt-bindings: fsl,fpga-qixis-i2c: add support for LX2160ARDB FPGA
> 
> > Extend the list of supported compatible strings with fsl,lx2160ardb-fpga.
> >
> > Since the register map exposed by the LX2160ARDB's FPGA also contains
> > two GPIO controllers, accept the necessary GPIO pattern property.
> > At the same time, add the #address-cells and #size-cells properties as
> > valid ones so that the child nodes of the fsl,lx2160ardb-fpga node are
> > addressable.
> >
> > This is needed because when defining child devices such as the GPIO
> > controller described in the added example, the child device needs a the
> > reg property to properly identify its register location.
> 
> These are neccesary because reg of child gpio controller nodes is in I2C
> device's address space.

Will incorporate the remark in this paragraph.

> 
> need empty line here.

Ok.

> 
> > Impose this restriction for the new compatible through an if-statement.
> >
> > Signed-off-by: Ioana Ciornei <ioana.ciornei@....com>
> > ---
> > Changes in v2:
> > - Enforce a unit address on the child gpios nodes (remove the ?)
> > - Enforce the use of unit addresses by having #address-size and
> >   #size-cells only for the newly added fsl,lx2160ardb-fpga compatible
> >
> >  .../bindings/board/fsl,fpga-qixis-i2c.yaml    | 47 +++++++++++++++++++
> >  1 file changed, 47 insertions(+)
> >
> ...
> 
> >
> > +allOf:
> > +  - if:
> > +      properties:
> > +        compatible:
> > +          contains:
> > +            enum:
> > +              - fsl,lx2160ardb-fpga
> > +    then:
> > +      required:
> > +        - "#address-cells"
> > +        - "#size-cells"
> > +
>        else:
>          properties:
>            '#address-cells': false
>            'size-cells': false

So that we also catch the cases in which address-cells/size-cells
shoudn't be used. Will do.

Thanks,
Ioana