linux-kernel - Re: [PATCH v2 3/9] mfd: simple-mfd-i2c: add compatible string for LX2160ARDB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <p2sy5l7us7tviqd6f3r2llqsowm4tywp6xymihprcafbb2ab5z@xihsv5fsvq53>
Date: Wed, 17 Sep 2025 10:21:41 +0300
From: Ioana Ciornei <ioana.ciornei@....com>
To: Frank Li <Frank.li@....com>
Cc: Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Linus Walleij <linus.walleij@...aro.org>, Bartosz Golaszewski <brgl@...ev.pl>, 
	Shawn Guo <shawnguo@...nel.org>, Michael Walle <mwalle@...nel.org>, Lee Jones <lee@...nel.org>, 
	devicetree@...r.kernel.org, linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 3/9] mfd: simple-mfd-i2c: add compatible string for
 LX2160ARDB

On Tue, Sep 16, 2025 at 12:20:24PM -0400, Frank Li wrote:
> On Mon, Sep 15, 2025 at 03:23:48PM +0300, Ioana Ciornei wrote:
> > Extend the list of supported devices with the QIXIS FPGA found on the
> > LX2160ARDB board.
> >
> > Signed-off-by: Ioana Ciornei <ioana.ciornei@....com>
> > ---
> > Changes in v2:
> > - none
> >
> >  drivers/mfd/simple-mfd-i2c.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/mfd/simple-mfd-i2c.c b/drivers/mfd/simple-mfd-i2c.c
> > index 63ac26388860..6fbe85437d8d 100644
> > --- a/drivers/mfd/simple-mfd-i2c.c
> > +++ b/drivers/mfd/simple-mfd-i2c.c
> > @@ -115,6 +115,7 @@ static const struct of_device_id simple_mfd_i2c_of_match[] = {
> >  	{ .compatible = "maxim,max5970", .data = &maxim_max5970},
> >  	{ .compatible = "maxim,max5978", .data = &maxim_max5970},
> >  	{ .compatible = "maxim,max77705-battery", .data = &maxim_mon_max77705},
> > +	{ .compatible = "fsl,lx2160ardb-fpga" },
> 
> driver data is the same as fsl,lx2160aqds-fpga.
> 
> why not fallback to fsl,lx2160aqds-fpga in dts file ?
> 

The register layout of the FPGA is different between the RDB and QDS
boards. Even though there is no difference in terms of the
simple-mfd-i2c driver, I still want to have the ability to differentiate
between them. Also, the if/then added in patch 2/9 would not be
possible.