linux-kernel - Re: [PATCH v4 2/3] sched: make migrate_enable/migrate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5041847.31r3eYUQgx@7940hx>
Date: Wed, 17 Sep 2025 09:25:44 +0800
From: Menglong Dong <menglong.dong@...ux.dev>
To: Peter Zijlstra <peterz@...radead.org>, ast@...nel.org
Cc: mingo@...hat.com, juri.lelli@...hat.com, vincent.guittot@...aro.org,
 dietmar.eggemann@....com, rostedt@...dmis.org, bsegall@...gle.com,
 mgorman@...e.de, vschneid@...hat.com, daniel@...earbox.net,
 john.fastabend@...il.com, andrii@...nel.org, martin.lau@...ux.dev,
 eddyz87@...il.com, song@...nel.org, yonghong.song@...ux.dev,
 kpsingh@...nel.org, sdf@...ichev.me, haoluo@...gle.com, jolsa@...nel.org,
 tzimmermann@...e.de, simona.vetter@...ll.ch, jani.nikula@...el.com,
 linux-kernel@...r.kernel.org, bpf@...r.kernel.org
Subject: Re: [PATCH v4 2/3] sched: make migrate_enable/migrate_disable inline

On 2025/9/16 19:07 Peter Zijlstra <peterz@...radead.org> write:
> On Thu, Aug 28, 2025 at 02:03:53PM +0800, Menglong Dong wrote:
> 
> > +/* The "struct rq" is not available here, so we can't access the
> > + * "runqueues" with this_cpu_ptr(), as the compilation will fail in
> > + * this_cpu_ptr() -> raw_cpu_ptr() -> __verify_pcpu_ptr():
> > + *   typeof((ptr) + 0)
> > + *
> > + * So use arch_raw_cpu_ptr()/PERCPU_PTR() directly here.
> > + */
> 
> Please fix broken comment style while you fix that compile error.

It's a little embarrassing. The compile error is caused by the commit
1b93c03fb319 ("rcu: add rcu_read_lock_dont_migrate()") in bpf-next tree,
which uses migrate_enable/migrate_disable in include/linux/rcupdate.h
but include the <linux/preempt.h>.

I can fix it by replace the linux/preempt.h with linux/sched.h, but should
I fix it in this series? I mean, the commit 1b93c03fb319 doesn't exist in
the tip for now :/

Thanks!
Menglong Dong

> 
>