linux-kernel - RE: [PATCH v3 2/7] dt-bindings: media: fsd: Add CSIS video capture interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <025001dc27cc$72be7b90$583b72b0$@samsung.com>
Date: Wed, 17 Sep 2025 17:43:10 +0530
From: "Inbaraj E" <inbaraj.e@...sung.com>
To: "'Krzysztof Kozlowski'" <krzk@...nel.org>
Cc: <rmfrfs@...il.com>, <laurent.pinchart@...asonboard.com>,
	<martink@...teo.de>, <kernel@...i.sm>, <mchehab@...nel.org>,
	<robh@...nel.org>, <krzk+dt@...nel.org>, <conor+dt@...nel.org>,
	<shawnguo@...nel.org>, <s.hauer@...gutronix.de>, <kernel@...gutronix.de>,
	<festevam@...il.com>, <linux-media@...r.kernel.org>,
	<devicetree@...r.kernel.org>, <imx@...ts.linux.dev>,
	<linux-arm-kernel@...ts.infradead.org>, <linux-kernel@...r.kernel.org>,
	<linux-samsung-soc@...r.kernel.org>, <pankaj.dubey@...sung.com>,
	<ravi.patel@...sung.com>, <shradha.t@...sung.com>
Subject: RE: [PATCH v3 2/7] dt-bindings: media: fsd: Add CSIS video capture
 interface

Hi Krzysztof,

Thanks for the review.

> > +title: Tesla FSD SoC MIPI CSI-2 video capture interface(Bridge device).
> 
> Drop final full stop. Also missing space before (

Will take care in next patchset.

> 
> 
> > +
> > +maintainers:
> > +  - Inbaraj E <inbaraj.e@...sung.com>
> > +
> > +description:
> > +  The Tesla FSD CSIS has an internal video capture interface to
> > +capture
> > +
> > +examples:
> > +  - |
> > +    #include <dt-bindings/clock/fsd-clk.h>
> > +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> > +
> > +    csis0: csis@...41000 {
> 
> Incorrect unit address.

Thanks for pointing out.
Unit address is correct. Address in reg is wrong here I'll fix in next patchset.

> 
> > +        compatible = "tesla,fsd-csis-media";
> > +        reg = <0x12661000 0x44c>;
> 
> 

Regards,
Inbaraj E