linux-kernel - Re: [PATCH] drivers/base/node: Fix double free in register_one

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aMwJU37LhxCUO6pZ@localhost.localdomain>
Date: Thu, 18 Sep 2025 15:29:55 +0200
From: Oscar Salvador <osalvador@...e.de>
To: Donet Tom <donettom@...ux.ibm.com>
Cc: akpm@...ux-foundation.org, clm@...a.com, Jonathan.Cameron@...wei.com,
	alison.schofield@...el.com, dakr@...nel.org, dave.jiang@...el.com,
	david@...hat.com, gregkh@...uxfoundation.org,
	kamezawa.hiroyu@...fujitsu.com, linux-kernel@...r.kernel.org,
	linux-mm@...ck.org, rafael@...nel.org, ritesh.list@...il.com,
	yury.norov@...il.com, ziy@...dia.com
Subject: Re: [PATCH] drivers/base/node: Fix double free in register_one_node()

On Thu, Sep 18, 2025 at 11:11:44AM +0530, Donet Tom wrote:
> When device_register() fails in register_node(), it calls
> put_device(&node->dev). This triggers node_device_release(),
> which calls kfree(to_node(dev)), thereby freeing the entire
> node structure.
> 
> As a result, when register_node() returns an error, the node
> memory has already been freed. Calling kfree(node) again in
> register_one_node() leads to a double free.
> 
> This patch removes the redundant kfree(node) from
> register_one_node() to prevent the double free.
> 
> Fixes: 786eb990cfb7 ("drivers/base/node: handle error properly in register_one_node()")
> Signed-off-by: Donet Tom <donettom@...ux.ibm.com>

Acked-by: Oscar Salvador <osalvador@...e.de>

 

-- 
Oscar Salvador
SUSE Labs