linux-kernel - Re: [PATCH] drivers/base/node: Fix double free in register_one

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aMwI8n2-w1J_AOiD@localhost.localdomain>
Date: Thu, 18 Sep 2025 15:28:18 +0200
From: Oscar Salvador <osalvador@...e.de>
To: David Hildenbrand <david@...hat.com>
Cc: Donet Tom <donettom@...ux.ibm.com>, akpm@...ux-foundation.org,
	clm@...a.com, Jonathan.Cameron@...wei.com,
	alison.schofield@...el.com, dakr@...nel.org, dave.jiang@...el.com,
	gregkh@...uxfoundation.org, kamezawa.hiroyu@...fujitsu.com,
	linux-kernel@...r.kernel.org, linux-mm@...ck.org, rafael@...nel.org,
	ritesh.list@...il.com, yury.norov@...il.com, ziy@...dia.com
Subject: Re: [PATCH] drivers/base/node: Fix double free in register_one_node()

On Thu, Sep 18, 2025 at 07:55:07AM +0200, David Hildenbrand wrote:
> Yes, that matches what other users (staring at mm/memory-tiers.c) do.
> 
> I wonder if we should just inline register_node() into register_one_node().
> 
> Then it's clearer that we perform a put_device() already in there.
> 
> On top of that, we could then just s/register_one_node/register_node/
> 
> And then we could do a similar cleanup for unregister_one_node /
> unregister_node where I don't consider the split function really valuable.

Yap, that makes sense to me as well.

 

-- 
Oscar Salvador
SUSE Labs