linux-kernel - Re: [PATCH v3 1/5] dt-bindings: touchscreen: convert bu21013 bindings to json schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250918-turkey-of-inescapable-freedom-1a1b1c@kuoka>
Date: Thu, 18 Sep 2025 11:12:58 +0900
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Dario Binacchi <dario.binacchi@...rulasolutions.com>
Cc: linux-kernel@...r.kernel.org, linux-amarula@...rulasolutions.com, 
	Conor Dooley <conor+dt@...nel.org>, Dmitry Torokhov <dmitry.torokhov@...il.com>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Rob Herring <robh@...nel.org>, devicetree@...r.kernel.org, 
	linux-input@...r.kernel.org
Subject: Re: [PATCH v3 1/5] dt-bindings: touchscreen: convert bu21013
 bindings to json schema

On Sun, Sep 14, 2025 at 10:37:52PM +0200, Dario Binacchi wrote:
> diff --git a/Documentation/devicetree/bindings/input/touchscreen/bu21013.yaml b/Documentation/devicetree/bindings/input/touchscreen/bu21013.yaml
> new file mode 100644
> index 000000000000..aeb581fcaf29
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/input/touchscreen/bu21013.yaml

Filename based on compatible, so rohm,bu21013.yaml

> @@ -0,0 +1,96 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/input/touchscreen/bu21013.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Rohm BU21013 touchscreen
> +
> +description:
> +  Rohm BU21013 I2C driven touchscreen controller.
> +
> +maintainers:
> +  - Dario Binacchi <dario.binacchi@...rulasolutions.com>
> +
> +allOf:
> +  - $ref: touchscreen.yaml#
> +
> +properties:
> +  compatible:
> +    enum:
> +      - rohm,bu21013_tp
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  reset-gpios:
> +    maxItems: 1
> +    description: GPIO resetting the chip

Drop description, obvious.

> +
> +  touch-gpios:
> +    maxItems: 1
> +    description: GPIO registering a touch event.
> +
> +  avdd-supply:
> +    description: Phandle to the regulator supplying the analog circuit.

Analog circuit supply.
(rest is redundant, it cannot be something else than phandle)

With these fixed:

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Best regards,
Krzysztof