linux-kernel - Re: [PATCH v3 2/5] dt-bindings: touchscreen: convert eeti bindings to json schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aMx0UFYsvIRbrCp2@lizhi-Precision-Tower-5810>
Date: Thu, 18 Sep 2025 17:06:24 -0400
From: Frank Li <Frank.li@....com>
To: Dario Binacchi <dario.binacchi@...rulasolutions.com>
Cc: linux-kernel@...r.kernel.org, linux-amarula@...rulasolutions.com,
	Conor Dooley <conor+dt@...nel.org>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Rob Herring <robh@...nel.org>, devicetree@...r.kernel.org,
	linux-input@...r.kernel.org
Subject: Re: [PATCH v3 2/5] dt-bindings: touchscreen: convert eeti bindings
 to json schema

On Sun, Sep 14, 2025 at 10:37:53PM +0200, Dario Binacchi wrote:
> Convert EETI touchscreen controller device tree binding to json-schema.
>
> Signed-off-by: Dario Binacchi <dario.binacchi@...rulasolutions.com>
>
> ---
>
> (no changes since v2)
>
> Changes in v2:
> - Added in v2
>
>  .../bindings/input/touchscreen/eeti.txt       | 30 ---------
>  .../bindings/input/touchscreen/eeti.yaml      | 62 +++++++++++++++++++

I think it should be merged into
Documentation/devicetree/bindings/input/touchscreen/eeti,exc3000.yaml

Just add new compatible string "eeti,exc3000-i2c"

or direct use eeti,exc3000 and remove .../bindings/input/touchscreen/eeti.txt

Frank

>  2 files changed, 62 insertions(+), 30 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/input/touchscreen/eeti.txt
>  create mode 100644 Documentation/devicetree/bindings/input/touchscreen/eeti.yaml
>
> diff --git a/Documentation/devicetree/bindings/input/touchscreen/eeti.txt b/Documentation/devicetree/bindings/input/touchscreen/eeti.txt
> deleted file mode 100644
> index 32b3712c916e..000000000000
> --- a/Documentation/devicetree/bindings/input/touchscreen/eeti.txt
> +++ /dev/null
> @@ -1,30 +0,0 @@
> -Bindings for EETI touchscreen controller
> -
> -Required properties:
> -- compatible:	should be "eeti,exc3000-i2c"
> -- reg:		I2C address of the chip. Should be set to <0xa>
> -- interrupts:	interrupt to which the chip is connected
> -
> -Optional properties:
> -- attn-gpios:	A handle to a GPIO to check whether interrupt is still
> -		latched. This is necessary for platforms that lack
> -		support for level-triggered IRQs.
> -
> -The following optional properties described in touchscreen.txt are
> -also supported:
> -
> -- touchscreen-inverted-x
> -- touchscreen-inverted-y
> -- touchscreen-swapped-x-y
> -
> -Example:
> -
> -i2c-master {
> -	touchscreen@a {
> -		compatible = "eeti,exc3000-i2c";
> -		reg = <0xa>;
> -		interrupt-parent = <&gpio>;
> -		interrupts = <123 IRQ_TYPE_EDGE_RISING>;
> -		attn-gpios = <&gpio 123 GPIO_ACTIVE_HIGH>;
> -	};
> -};
> diff --git a/Documentation/devicetree/bindings/input/touchscreen/eeti.yaml b/Documentation/devicetree/bindings/input/touchscreen/eeti.yaml
> new file mode 100644
> index 000000000000..97027914d6a6
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/input/touchscreen/eeti.yaml
> @@ -0,0 +1,62 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/input/touchscreen/eeti.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: EETI touchscreen controller
> +
> +description:
> +  EETI I2C driven touchscreen controller.
> +
> +maintainers:
> +  - Dario Binacchi <dario.binacchi@...rulasolutions.com>
> +
> +allOf:
> +  - $ref: touchscreen.yaml#
> +
> +properties:
> +  compatible:
> +    enum:
> +      - eeti,exc3000-i2c
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  attn-gpios:
> +    maxItems: 1
> +    description: Phandle to a GPIO to check whether interrupt is still
> +                 latched. This is necessary for platforms that lack
> +                 support for level-triggered IRQs.
> +
> +  touchscreen-inverted-x: true
> +  touchscreen-inverted-y: true
> +  touchscreen-swapped-x-y: true
> +
> +additionalProperties: false
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +
> +examples:
> +  - |
> +    #include <dt-bindings/gpio/gpio.h>
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        touchscreen@a {
> +            compatible = "eeti,exc3000-i2c";
> +            reg = <0xa>;
> +
> +            interrupt-parent = <&gpio>;
> +            interrupts = <123 IRQ_TYPE_EDGE_RISING>;
> +            attn-gpios = <&gpio 123 GPIO_ACTIVE_HIGH>;
> +        };
> +    };
> --
> 2.43.0
>
> base-commit: df86f912b45c20e236060321c85fe35437e9325d
> branch: drop-touchscreen.txt