linux-kernel - Re: [PATCH 1/3] rust: miscdevice: Moved `MiscDevice` to a more general abstraction

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2025091803-rephrase-deepen-52fd@gregkh>
Date: Thu, 18 Sep 2025 17:00:32 +0200
From: "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
To: ManeraKai <manerakai@...tonmail.com>
Cc: "aliceryhl@...gle.com" <aliceryhl@...gle.com>,
	"arnd@...db.de" <arnd@...db.de>,
	"rust-for-linux@...r.kernel.org" <rust-for-linux@...r.kernel.org>,
	"linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/3] rust: miscdevice: Moved `MiscDevice` to a more
 general abstraction

On Thu, Sep 18, 2025 at 02:45:28PM +0000, ManeraKai wrote:
> This new general abstraction is called `FileOperations`.
> 
> `struct file_operations` is not only meant for misc. Its methods are
> accessible from any other driver type. This change, however, doesn't
> generalize the safe wrapping for all driver types, but rather just the
> method declarations. The actual safe wrappings are left for every driver
> type to implement. This may make each implementation simpler. For
> example, misc can choose not to implement the safe wrapping for `lock`,
> `sendfile`, or `sendpage`, since they have no use in misc drivers.

This has come up many times, but we really are not "ready" for a generic
file operations export.  Let's keep this just for misc for now, until we
have another use for it, as the interaction with the vfs is tricky and
subtle and full of corner cases (see the debugfs bindings for lots of
examples here.)

So for a misc device, let's just stick with what we have for now.

> Signed-off-by: ManeraKai <manerakai@...tonmail.com>

Nit, we need a full name please.

thanks,

greg k-h