linux-kernel - Re: [PATCH 3/3] samples: rust: Updated the example using the Rust MiscDevice abstraction

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2025091850-brownnose-applause-1dac@gregkh>
Date: Thu, 18 Sep 2025 17:01:26 +0200
From: "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
To: ManeraKai <manerakai@...tonmail.com>
Cc: "aliceryhl@...gle.com" <aliceryhl@...gle.com>,
	"arnd@...db.de" <arnd@...db.de>,
	"rust-for-linux@...r.kernel.org" <rust-for-linux@...r.kernel.org>,
	"linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/3] samples: rust: Updated the example using the Rust
 MiscDevice abstraction

On Thu, Sep 18, 2025 at 02:45:44PM +0000, ManeraKai wrote:
> This sample driver will now:
> - use the new general `FileOperations` abstraction.
> - have `read` and `write` methods, that use a persistent kernel buffer to
> store data.
> 
> Signed-off-by: ManeraKai <manerakai@...tonmail.com>
> ---
>  samples/rust/rust_misc_device.rs | 283 +++++++++++++++++++++----------
>  1 file changed, 195 insertions(+), 88 deletions(-)
> 
> diff --git a/samples/rust/rust_misc_device.rs b/samples/rust/rust_misc_device.rs
> index d052294cebb8..c8e90eb9b9ad 100644
> --- a/samples/rust/rust_misc_device.rs
> +++ b/samples/rust/rust_misc_device.rs
> @@ -7,92 +7,139 @@
>  //! Below is an example userspace C program that exercises this sample's functionality.
>  //!
>  //! ```c
> -//! #include <stdio.h>

You seem to have dropped the leading ' ' character, which makes this
diff almost impossible to review :(

Please fix that up and only change the modified files, not all of them,
in the example.

thanks,

greg k-h