linux-kernel - Re: [PATCH 2/3] rust: miscdevice: Implemented `read` and `write`

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2025091841-remindful-manned-a57f@gregkh>
Date: Thu, 18 Sep 2025 17:06:37 +0200
From: "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
To: ManeraKai <manerakai@...tonmail.com>
Cc: "aliceryhl@...gle.com" <aliceryhl@...gle.com>,
	"arnd@...db.de" <arnd@...db.de>,
	"rust-for-linux@...r.kernel.org" <rust-for-linux@...r.kernel.org>,
	"linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/3] rust: miscdevice: Implemented `read` and `write`

On Thu, Sep 18, 2025 at 04:59:01PM +0200, gregkh@...uxfoundation.org wrote:
> On Thu, Sep 18, 2025 at 02:45:36PM +0000, ManeraKai wrote:
> > Added the general declaration in `FileOperations`. And implemented the
> > safe wrapping for misc.
> 
> While read/write is "traditional", perhaps instead you should just
> export read_iter and write_iter as that is the proper way forward for
> drivers to be using.

Wait, maybe not.  The _iter stuff is "hard" for misc devices, and I
don't think that any of the current ones use that, so nevermind, a
simple read/write should be all that we need here.

What type of real misc driver do you want to write in rust that you need
a read/write callback and not just an ioctl one?

thanks,

greg k-h