[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <wbfsxrvwb4ky3irnwm5vohmwyek3c4uskxg3dnfzrfadyx4aay@5udf6eht3cdj>
Date: Sat, 20 Sep 2025 13:04:29 +0530
From: Manivannan Sadhasivam <mani@...nel.org>
To: Richard Zhu <hongxing.zhu@....com>
Cc: frank.li@....com, jingoohan1@...il.com, l.stach@...gutronix.de,
lpieralisi@...nel.org, kwilczynski@...nel.org, robh@...nel.org, bhelgaas@...gle.com,
shawnguo@...nel.org, s.hauer@...gutronix.de, kernel@...gutronix.de,
festevam@...il.com, linux-pci@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
imx@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/2] PCI: imx6: Add a method to handle CLKREQ# override
On Wed, Sep 17, 2025 at 05:37:49PM +0800, Richard Zhu wrote:
> The CLKREQ# is an open drain, active low signal that is driven low by
> the card to request reference clock.
>
> But the CLKREQ# maybe reserved on some old device, compliant with CEM
> r3.0 or before. Thus, this signal wouldn't be driven low by these old
> devices.
>
> Since the reference clock controlled by CLKREQ# may be required by i.MX
> PCIe host too. To make sure this clock is ready even when the CLKREQ#
> isn't driven low by the card(e.x old cards described above), force
> CLKREQ# override active low for i.MX PCIe host during initialization.
>
> The CLKREQ# override can be cleared safely when supports-clkreq is
> present and PCIe link is up later. Because the CLKREQ# would be driven
> low by the card in this case.
>
> Main changes in v2:
> - Update the commit message, and collect the reviewed-by tag.
>
> [PATCH v2 1/2] PCI: dwc: Invoke post_init in dw_pcie_resume_noirq()
> [PATCH v2 2/2] PCI: imx6: Add a method to handle CLKREQ# override
>
Patch 2 is not applying on top of 6.17-rc1. Please fix it and resend the series
(along with the CEM 4.0 citation suggested by Bjorn).
- Mani
--
மணிவண்ணன் சதாசிவம்
Powered by blists - more mailing lists