linux-kernel - Re: [PATCH 2/3] pinctrl: qcom: spmi-gpio: Add PMCX0102, PMK8850 & PMH01XX PMICs support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7sso6x5tkrnpihczkfxush2jax3hq5q456ftidzbumlbrwzgph@dws6xkfsbwcr>
Date: Sat, 20 Sep 2025 21:39:49 -0500
From: Bjorn Andersson <andersson@...nel.org>
To: Kamal Wadhwa <kamal.wadhwa@....qualcomm.com>
Cc: Stephen Boyd <sboyd@...nel.org>, 
	Linus Walleij <linus.walleij@...aro.org>, linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org, 
	linux-gpio@...r.kernel.org, Jishnu Prakash <jishnu.prakash@....qualcomm.com>, 
	Anjelique Melendez <anjelique.melendez@....qualcomm.com>
Subject: Re: [PATCH 2/3] pinctrl: qcom: spmi-gpio: Add PMCX0102, PMK8850 &
 PMH01XX PMICs support

On Sat, Sep 20, 2025 at 01:30:10AM +0530, Kamal Wadhwa wrote:
> From: Anjelique Melendez <anjelique.melendez@....qualcomm.com>
> 
> Add support for PMCX0102, PMH0101, PMH0104, PMH0110 and PMK8850 PMIC
> GPIOs with adding appropriate compatible strings.
> 

This patch (and patch 3) doesn't seem to actually have a dependency on
patch 1 in this series, so it would have been better to be send in a
separate series.

I do however believe this patch should have been sent together with
https://lore.kernel.org/all/20250919141440.1068770-1-pankaj.patil@oss.qualcomm.com/ 

Regards,
Bjorn

> Signed-off-by: Anjelique Melendez <anjelique.melendez@....qualcomm.com>
> Signed-off-by: Jishnu Prakash <jishnu.prakash@....qualcomm.com>
> Signed-off-by: Kamal Wadhwa <kamal.wadhwa@....qualcomm.com>
> ---
>  drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
> index 485b68cc93f8edac07c15aad50ff5c9c7894d8bc..c4f7d2d7a017684cd9c0d0850cb8d998668b543e 100644
> --- a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
> +++ b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
> @@ -1239,7 +1239,11 @@ static const struct of_device_id pmic_gpio_of_match[] = {
>  	{ .compatible = "qcom,pm8998-gpio", .data = (void *) 26 },
>  	{ .compatible = "qcom,pma8084-gpio", .data = (void *) 22 },
>  	{ .compatible = "qcom,pmc8380-gpio", .data = (void *) 10 },
> +	{ .compatible = "qcom,pmcx0102-gpio", .data = (void *)14 },
>  	{ .compatible = "qcom,pmd8028-gpio", .data = (void *) 4 },
> +	{ .compatible = "qcom,pmh0101-gpio", .data = (void *)18 },
> +	{ .compatible = "qcom,pmh0104-gpio", .data = (void *)8 },
> +	{ .compatible = "qcom,pmh0110-gpio", .data = (void *)14 },
>  	{ .compatible = "qcom,pmi632-gpio", .data = (void *) 8 },
>  	{ .compatible = "qcom,pmi8950-gpio", .data = (void *) 2 },
>  	{ .compatible = "qcom,pmi8994-gpio", .data = (void *) 10 },
> @@ -1248,6 +1252,7 @@ static const struct of_device_id pmic_gpio_of_match[] = {
>  	{ .compatible = "qcom,pmiv0104-gpio", .data = (void *) 10 },
>  	{ .compatible = "qcom,pmk8350-gpio", .data = (void *) 4 },
>  	{ .compatible = "qcom,pmk8550-gpio", .data = (void *) 6 },
> +	{ .compatible = "qcom,pmk8850-gpio", .data = (void *)8 },
>  	{ .compatible = "qcom,pmm8155au-gpio", .data = (void *) 10 },
>  	{ .compatible = "qcom,pmm8654au-gpio", .data = (void *) 12 },
>  	/* pmp8074 has 12 GPIOs with holes on 1 and 12 */
> 
> -- 
> 2.25.1
>