linux-kernel - Re: [PATCH] dt-bindings: pinctrl: qcom,pmic-gpio: Add GPIO bindings for Glymur PMICs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <mp2elkdhqg2fsmvebwbxbxr5jyasfpzi4b5kbfxkjjxv433thc@7codfe5sp7pv>
Date: Sat, 20 Sep 2025 21:41:07 -0500
From: Bjorn Andersson <andersson@...nel.org>
To: Pankaj Patil <pankaj.patil@....qualcomm.com>
Cc: linus.walleij@...aro.org, robh@...nel.org, krzk+dt@...nel.org, 
	conor+dt@...nel.org, linux-arm-msm@...r.kernel.org, linux-gpio@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: pinctrl: qcom,pmic-gpio: Add GPIO bindings
 for Glymur PMICs

On Fri, Sep 19, 2025 at 07:44:40PM +0530, Pankaj Patil wrote:
> From: Jishnu Prakash <jishnu.prakash@....qualcomm.com>

This doesn't match the first signed-off-by.

> 
> Update the Qualcomm Technologies, Inc. PMIC GPIO binding documentation
> to include compatible strings for PMK8850, PMH0101, PMH0104, PMH0110
> and PMCX0102 PMICs.
> 

Looks good, but this should be sent together with the related driver
change.

Thank you,
Bjorn

> Signed-off-by: Anjelique Melendez <anjelique.melendez@....qualcomm.com>
> Signed-off-by: Jishnu Prakash <jishnu.prakash@....qualcomm.com>
> Signed-off-by: Pankaj Patil <pankaj.patil@....qualcomm.com>
> ---
>  .../bindings/pinctrl/qcom,pmic-gpio.yaml          | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
> index 5e6dfcc3fe9b..8ae4489637f3 100644
> --- a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
> @@ -59,7 +59,11 @@ properties:
>            - qcom,pmc8180-gpio
>            - qcom,pmc8180c-gpio
>            - qcom,pmc8380-gpio
> +          - qcom,pmcx0102-gpio
>            - qcom,pmd8028-gpio
> +          - qcom,pmh0101-gpio
> +          - qcom,pmh0104-gpio
> +          - qcom,pmh0110-gpio
>            - qcom,pmi632-gpio
>            - qcom,pmi8950-gpio
>            - qcom,pmi8994-gpio
> @@ -68,6 +72,7 @@ properties:
>            - qcom,pmiv0104-gpio
>            - qcom,pmk8350-gpio
>            - qcom,pmk8550-gpio
> +          - qcom,pmk8850-gpio
>            - qcom,pmm8155au-gpio
>            - qcom,pmm8654au-gpio
>            - qcom,pmp8074-gpio
> @@ -191,6 +196,8 @@ allOf:
>                - qcom,pm8950-gpio
>                - qcom,pm8953-gpio
>                - qcom,pmi632-gpio
> +              - qcom,pmh0104-gpio
> +              - qcom,pmk8850-gpio
>      then:
>        properties:
>          gpio-line-names:
> @@ -303,6 +310,8 @@ allOf:
>          compatible:
>            contains:
>              enum:
> +              - qcom,pmcx0102-gpio
> +              - qcom,pmh0110-gpio
>                - qcom,pmi8998-gpio
>      then:
>        properties:
> @@ -318,6 +327,7 @@ allOf:
>          compatible:
>            contains:
>              enum:
> +              - qcom,pmh0101-gpio
>                - qcom,pmih0108-gpio
>      then:
>        properties:
> @@ -481,13 +491,18 @@ $defs:
>                   - gpio1-gpio22 for pm8994
>                   - gpio1-gpio26 for pm8998
>                   - gpio1-gpio22 for pma8084
> +                 - gpio1-gpio14 for pmcx0102
>                   - gpio1-gpio4 for pmd8028
> +                 - gpio1-gpio18 for pmh0101
> +                 - gpio1-gpio8 for pmh0104
> +                 - gpio1-gpio14 for pmh0110
>                   - gpio1-gpio8 for pmi632
>                   - gpio1-gpio2 for pmi8950
>                   - gpio1-gpio10 for pmi8994
>                   - gpio1-gpio18 for pmih0108
>                   - gpio1-gpio4 for pmk8350
>                   - gpio1-gpio6 for pmk8550
> +                 - gpio1-gpio8 for pmk8850
>                   - gpio1-gpio10 for pmm8155au
>                   - gpio1-gpio12 for pmm8654au
>                   - gpio1-gpio12 for pmp8074 (holes on gpio1 and gpio12)
> -- 
> 2.34.1
>