[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20250922170534.GA468503-robh@kernel.org>
Date: Mon, 22 Sep 2025 12:05:34 -0500
From: Rob Herring <robh@...nel.org>
To: Gatien Chevallier <gatien.chevallier@...s.st.com>
Cc: Andrew Lunn <andrew+netdev@...n.ch>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>,
Maxime Coquelin <mcoquelin.stm32@...il.com>,
Alexandre Torgue <alexandre.torgue@...s.st.com>,
Christophe Roullier <christophe.roullier@...s.st.com>,
Andrew Lunn <andrew@...n.ch>,
Heiner Kallweit <hkallweit1@...il.com>,
Russell King <linux@...linux.org.uk>,
Simon Horman <horms@...nel.org>,
Tristram Ha <Tristram.Ha@...rochip.com>,
Florian Fainelli <florian.fainelli@...adcom.com>,
netdev@...r.kernel.org, devicetree@...r.kernel.org,
linux-stm32@...md-mailman.stormreply.com,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v2 1/4] dt-bindings: net: document st,phy-wol
property
On Wed, Sep 17, 2025 at 05:36:36PM +0200, Gatien Chevallier wrote:
> Add the "st,phy-wol" to indicate the MAC to use the wakeup capability
> of the PHY instead of the MAC.
Why is this ST specific? PHYs being wakeup capable or not is independent
of ST. If you want to or can use wakeup from the PHY, shouldn't that be
a property in the PHY?
Seems to me you would want to define what all components are wakeup
capable and then let the kernel decide which component to use. I'd think
the kernel would prefer the PHY as that's closest to the wire and
probably lowest power.
That's my 2 cents spending all of 5 minutes thinking about it. I'll
defer to Russell and Andrew...
Rob
Powered by blists - more mailing lists