linux-kernel - Re: [PATCH net-next v2 1/4] dt-bindings: net: document st,phy-wol property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <89d4f257-0326-4bc7-bf53-6a2175f139ec@foss.st.com>
Date: Tue, 23 Sep 2025 10:02:30 +0200
From: Gatien CHEVALLIER <gatien.chevallier@...s.st.com>
To: Rob Herring <robh@...nel.org>
CC: Andrew Lunn <andrew+netdev@...n.ch>,
        "David S. Miller"
	<davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
	<kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Krzysztof Kozlowski
	<krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Maxime Coquelin
	<mcoquelin.stm32@...il.com>,
        Alexandre Torgue <alexandre.torgue@...s.st.com>,
        Christophe Roullier <christophe.roullier@...s.st.com>,
        Andrew Lunn
	<andrew@...n.ch>, Heiner Kallweit <hkallweit1@...il.com>,
        Russell King
	<linux@...linux.org.uk>, Simon Horman <horms@...nel.org>,
        Tristram Ha
	<Tristram.Ha@...rochip.com>,
        Florian Fainelli
	<florian.fainelli@...adcom.com>,
        <netdev@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-stm32@...md-mailman.stormreply.com>,
        <linux-arm-kernel@...ts.infradead.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next v2 1/4] dt-bindings: net: document st,phy-wol
 property



On 9/22/25 19:05, Rob Herring wrote:
> On Wed, Sep 17, 2025 at 05:36:36PM +0200, Gatien Chevallier wrote:
>> Add the  "st,phy-wol" to indicate the MAC to use the wakeup capability
>> of the PHY instead of the MAC.
> 
> Why is this ST specific? PHYs being wakeup capable or not is independent
> of ST. If you want to or can use wakeup from the PHY, shouldn't that be
> a property in the PHY?
> 
> Seems to me you would want to define what all components are wakeup
> capable and then let the kernel decide which component to use. I'd think
> the kernel would prefer the PHY as that's closest to the wire and
> probably lowest power.
> 
> That's my 2 cents spending all of 5 minutes thinking about it. I'll
> defer to Russell and Andrew...
> 
> Rob

Hi Rob,

I think we're all aligned on this now. The thing about this property
being added is really related to how the STMMAC driver was interacting
with the PHY drivers and how the PHY drivers communicate their WoL
capability. It has been done previously for the "mediatek,mac-wol"
property.

The complicated thing to handle is: Is the PHY capable of doing WoL
AND is the wiring actually present on the platform on the correct
pin.

I'll send a V3 taking into account the different discussions we had
with Andrew and Russell.

Best regards,
Gatien