Message-Id: <175856183997.499955.3596561052820030372.robh@kernel.org>
Date: Mon, 22 Sep 2025 12:27:44 -0500
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Chaoyi Chen <kernel@...kyi.com>
Cc: Diederik de Haas <didi.debian@...ow.org>, 
 Heikki Krogerus <heikki.krogerus@...ux.intel.com>, 
 Kishon Vijay Abraham I <kishon@...nel.org>, 
 Dragan Simic <dsimic@...jaro.org>, dri-devel@...ts.freedesktop.org, 
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>, 
 David Airlie <airlied@...il.com>, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
 Peter Robinson <pbrobinson@...il.com>, 
 Thomas Zimmermann <tzimmermann@...e.de>, 
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, 
 Amit Sunil Dhamne <amitsd@...gle.com>, Maxime Ripard <mripard@...nel.org>, 
 Andy Yan <andy.yan@...k-chips.com>, linux-phy@...ts.infradead.org, 
 linux-usb@...r.kernel.org, Frank Wang <frank.wang@...k-chips.com>, 
 Conor Dooley <conor+dt@...nel.org>, 
 Yubing Zhang <yubing.zhang@...k-chips.com>, 
 Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>, 
 Heiko Stuebner <heiko@...ech.de>, Johan Jonker <jbx6244@...il.com>, 
 linux-arm-kernel@...ts.infradead.org, 
 Chaoyi Chen <chaoyi.chen@...k-chips.com>, Vinod Koul <vkoul@...nel.org>, 
 Simona Vetter <simona@...ll.ch>, Sandy Huang <hjc@...k-chips.com>, 
 linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org, 
 devicetree@...r.kernel.org
Subject: Re: [PATCH v4 0/7] Add Type-C DP support for RK3399 EVB IND board


On Mon, 22 Sep 2025 09:20:32 +0800, Chaoyi Chen wrote:
> From: Chaoyi Chen <chaoyi.chen@...k-chips.com>
> 
> This series focuses on adding Type-C DP support for USBDP PHY and DP
> driver. The USBDP PHY and DP will perceive the changes in cable status
> based on the USB PD and Type-C state machines provided by TCPM. Before
> this, the USBDP PHY and DP controller of RK3399 sensed cable state
> changes through extcon, and devices such as the RK3399 Gru-Chromebook
> rely on them. This series should not break them.
> 
> ====
> 1. DisplayPort HPD status notify
> 
> Before v4, I implemented a variety of DP HPD status notify. However,
> they all had various problems and it was difficult to become a common
> solution.
> 
> Under Dmitry's guidance, I try to add default DRM AUX HPD device when
> register DisplayPort altmode in patch 1. That makes it redundant for
> each Type-C chip driver to implement a similar registration process
> in embedded scenarios.
> 
> I'm not certain if the current implementation is appropriate.
> Please let me know if there's a better way.
> 
> ====
> 2. Altmode switching and orientation switching for USBDP PHY
> 
> For USB Type-C interfaces, an external Type-C controller chip assists
> by detecting cable attachment, determining plug orientation, and
> reporting USB PD message. The USB/DP combo PHY supports software
> configurable pin mapping and DisplayPort lane assignment. Based on
> these message, the combo PHY can perform both altmode switching and
> orientation switching via software.
> 
> The RK3399 EVB IND board has a Type-C interface DisplayPort. It use
> fusb302 chip as Type-C controller. The connection diagram is shown below:
> 
> fusb302 chip +---> USB2.0 PHY ----> DWC3 USB controller
>              |
>              +---> USB/DP PHY0 +--> CDN-DP controller
>                                |
>                                +--> DWC3 USB controller
> 
> ====
> 3. Multiple bridge model for RK3399 CDN-DP
> 
> The RK3399 has two USB/DP combo PHY and one CDN-DP controller. And
> the CDN-DP can be switched to output to one of the PHYs.
> 
> USB/DP PHY0 ---+
>                | <----> CDN-DP controller
> USB/DP PHY1 ---+
> 
> In previous versions, if both PHY ports were connected to DP,
> the CDN-DP driver would select the first PHY port for output.
> 
> On Dmitry's suggestion, we introduced a multi-bridge model to support
> flexible selection of the output PHY port. For each PHY port, a
> separate encoder and bridge are registered.
> 
> The change is based on the DRM AUX HPD bridge, rather than the
> extcon approach. This requires the DT to correctly describe the
> connections between the PHY, USB connector, and DP controller.
> And cdn_dp_parse_hpd_bridge_dt() will parses it and determines
> whether to register one or two bridges.
> 
> ====
> Patch1 add default HPD device when register Displayport altmode.
> Patch2 add new Type-C mode switch for RK3399 USBDP phy binding.
> Patch3 add typec_mux and typec_switch for RK3399 USBDP PHY.
> Patch4 drops CDN-DP's extcon dependency when Type-C is present.
> Patch5 add multiple bridges to support PHY port selection.
> Patch6 add missing dp_out port for RK3399 CDN-DP.
> Patch7 add Type-C DP support for RK3399 EVB IND board.
> 
> Changes in v4:
> - Link to V3: https://lore.kernel.org/all/20250729090032.97-1-kernel@airkyi.com/
> - Add default HPD device for DisplayPort altmode.
> - Introduce multiple bridges for CDN-DP.
> - ...
> 
> Changes in v3:
> - Link to V2: https://lore.kernel.org/all/20250718062619.99-1-kernel@airkyi.com/
> - Add more descriptions to clarify the role of the PHY in switching.
> - Fix wrong vdo value.
> - Fix port node in usb-c-connector.
> 
> Changes in v2:
> - Link to V1: https://lore.kernel.org/all/20250715112456.101-1-kernel@airkyi.com/
> - Reuse dp-port/usb3-port in rk3399-typec-phy binding.
> - Fix compile error when CONFIG_TYPEC is not enabled.
> - Notify DP HPD state by USB/DP PHY.
> - Ignore duplicate HPD events.
> - Add endpoint to link DP PHY and DP controller.
> - Fix devicetree coding style.
> 
> Chaoyi Chen (7):
>   usb: typec: Add default HPD device when register DisplayPort altmode
>   dt-bindings: phy: rockchip: rk3399-typec-phy: Support mode-switch
>   phy: rockchip: phy-rockchip-typec: Add typec_mux/typec_switch support
>   drm/rockchip: cdn-dp: Support handle lane info without extcon
>   drm/rockchip: cdn-dp: Add multiple bridges to support PHY port
>     selection
>   arm64: dts: rockchip: Add missing dp_out port for RK3399 CDN-DP
>   arm64: dts: rockchip: rk3399-evb-ind: Add support for DisplayPort
> 
>  .../phy/rockchip,rk3399-typec-phy.yaml        |   6 +
>  arch/arm64/boot/dts/rockchip/rk3399-base.dtsi |  10 +-
>  .../boot/dts/rockchip/rk3399-evb-ind.dts      | 146 ++++++
>  drivers/gpu/drm/rockchip/Kconfig              |   1 +
>  drivers/gpu/drm/rockchip/cdn-dp-core.c        | 423 +++++++++++++++---
>  drivers/gpu/drm/rockchip/cdn-dp-core.h        |  23 +-
>  drivers/phy/rockchip/phy-rockchip-typec.c     | 365 ++++++++++++++-
>  drivers/usb/typec/altmodes/displayport.c      |  27 ++
>  drivers/usb/typec/altmodes/displayport.h      |   2 +
>  drivers/usb/typec/class.c                     |   8 +
>  include/linux/usb/typec_altmode.h             |   2 +
>  11 files changed, 932 insertions(+), 81 deletions(-)
> 
> --
> 2.49.0
> 
> 
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


This patch series was applied (using b4) to base:
 Base: attempting to guess base-commit...
 Base: tags/next-20250922 (best guess, 10/11 blobs matched)

If this is not the correct base, please add 'base-commit' tag
(or use b4 which does this automatically)

New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/rockchip/' for 20250922012039.323-1-kernel@...kyi.com:

arch/arm64/boot/dts/rockchip/rk3399-evb-ind.dtb: syscon@...70000 (rockchip,rk3399-grf): usb2phy@...0: 'port' does not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/soc/rockchip/grf.yaml#
arch/arm64/boot/dts/rockchip/rk3399-evb-ind.dtb: syscon@...70000 (rockchip,rk3399-grf): usb2phy@...0: Unevaluated properties are not allowed ('port' was unexpected)
	from schema $id: http://devicetree.org/schemas/soc/rockchip/grf.yaml#
arch/arm64/boot/dts/rockchip/rk3399-evb-ind.dtb: usb2phy@...0 (rockchip,rk3399-usb2phy): 'port' does not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/phy/rockchip,inno-usb2phy.yaml#
arch/arm64/boot/dts/rockchip/rk3399-evb-ind.dtb: /sound: failed to match any schema with compatible: ['rockchip,rk3399-gru-sound']

Powered by blists - more mailing lists