linux-kernel - Re: [PATCH iproute2-next 2/3] iplink_can: fix SPDX-License-Identifier tag format

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250922150822.3fce0568@hermes.local>
Date: Mon, 22 Sep 2025 15:08:22 -0700
From: Stephen Hemminger <stephen@...workplumber.org>
To: Vincent Mailhol <mailhol@...nel.org>
Cc: netdev@...r.kernel.org, David Ahern <dsahern@...il.com>, Marc
 Kleine-Budde <mkl@...gutronix.de>, Oliver Hartkopp
 <socketcan@...tkopp.net>, linux-kernel@...r.kernel.org,
 linux-can@...r.kernel.org
Subject: Re: [PATCH iproute2-next 2/3] iplink_can: fix
 SPDX-License-Identifier tag format

On Sun, 21 Sep 2025 16:32:31 +0900
Vincent Mailhol <mailhol@...nel.org> wrote:

> In .c files, the SPDX tag uses the C++ comment style.
> 
> Fix below checkpatch.pl warning:
> 
>   WARNING: Improper SPDX comment style for 'ip/iplink_can.c', please use '//' instead
>   #1: FILE: ip/iplink_can.c:1:
>   +/* SPDX-License-Identifier: GPL-2.0-or-later */
> 
>   WARNING: Missing or malformed SPDX-License-Identifier tag in line 1
>   #1: FILE: ip/iplink_can.c:1:
>   +/* SPDX-License-Identifier: GPL-2.0-or-later */
> 
> Signed-off-by: Vincent Mailhol <mailhol@...nel.org>

NAK
Iproute2 excepts both formats and both are used in several
places.