linux-kernel - Re: [PATCH iproute2-next 3/3] iplink_can: factorise the calls to usage()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250922150920.78b95c44@hermes.local>
Date: Mon, 22 Sep 2025 15:09:20 -0700
From: Stephen Hemminger <stephen@...workplumber.org>
To: Vincent Mailhol <mailhol@...nel.org>
Cc: netdev@...r.kernel.org, David Ahern <dsahern@...il.com>, Marc
 Kleine-Budde <mkl@...gutronix.de>, Oliver Hartkopp
 <socketcan@...tkopp.net>, linux-kernel@...r.kernel.org,
 linux-can@...r.kernel.org
Subject: Re: [PATCH iproute2-next 3/3] iplink_can: factorise the calls to
 usage()

On Sun, 21 Sep 2025 16:32:32 +0900
Vincent Mailhol <mailhol@...nel.org> wrote:

> usage() is called either if the user passes the "help" argument or passes
> an invalid argument.
> 
> Factorise those two cases together.
> 
> This silences below checkpatch.pl warning:
> 
>   WARNING: else is not generally useful after a break or return
>   #274: FILE: ip/iplink_can.c:274:
>   +			return -1;
>   +		} else {
> 
> Signed-off-by: Vincent Mailhol <mailhol@...nel.org>
> ---

Not accepting most checkpatch stuff in iproute2.
Better to not have code churn