linux-kernel - Re: [PATCH v3 1/4] crypto: ti: Add support for AES-XTS in DTHEv2 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c0196ac6-af65-48c1-bc5a-ca430dff0a5a@ti.com>
Date: Mon, 22 Sep 2025 18:06:31 +0530
From: T Pratham <t-pratham@...com>
To: Herbert Xu <herbert@...dor.apana.org.au>
CC: "David S. Miller" <davem@...emloft.net>,
        Kamlesh Gurudasani
	<kamlesh@...com>,
        Manorit Chawdhry <m-chawdhry@...com>,
        Vignesh Raghavendra
	<vigneshr@...com>,
        Praneeth Bajjuri <praneeth@...com>, Vishal Mahaveer
	<vishalm@...com>,
        Kavitha Malarvizhi <k-malarvizhi@...com>,
        <linux-crypto@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 1/4] crypto: ti: Add support for AES-XTS in DTHEv2
 driver

On 20/09/25 17:38, Herbert Xu wrote:
> On Wed, Sep 10, 2025 at 02:46:53PM +0530, T Pratham wrote:
>>
>> @@ -397,7 +446,29 @@ static struct skcipher_engine_alg cipher_algs[] = {
>>  			.cra_module		= THIS_MODULE,
>>  		},
>>  		.op.do_one_request = dthe_aes_run,
>> -	} /* CBC AES */
>> +	}, /* CBC AES */
>> +	{
>> +		.base.init			= dthe_cipher_init_tfm,
>> +		.base.setkey			= dthe_aes_xts_setkey,
>> +		.base.encrypt			= dthe_aes_encrypt,
>> +		.base.decrypt			= dthe_aes_decrypt,
>> +		.base.min_keysize		= AES_MIN_KEY_SIZE * 2,
>> +		.base.max_keysize		= AES_MAX_KEY_SIZE * 2,
>> +		.base.ivsize			= AES_IV_SIZE,
>> +		.base.base = {
>> +			.cra_name		= "xts(aes)",
>> +			.cra_driver_name	= "xts-aes-dthev2",
>> +			.cra_priority		= 299,
>> +			.cra_flags		= CRYPTO_ALG_TYPE_SKCIPHER |
>> +						  CRYPTO_ALG_KERN_DRIVER_ONLY,
> 
> I think it's missing CRYPTO_ALG_ASYNC.
> 
> The existing algorithms seem to be missing this bit too so we
> should fix that first.
> 
> Thanks,

Oh. Thanks for pointing this out. 
This series had a few more issues with some of the algorithms, so I was about to send another revision anyway. I'll also correct this. And also fix the existing algorithms as well.

-- 
Regards
T Pratham <t-pratham@...com>