linux-kernel - Re: [PATCH] scsi: smartpqi: Replace kmalloc + copy_from_user with memdup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <SJ2PR11MB83697AF910EED3F2C5D3C082E11DA@SJ2PR11MB8369.namprd11.prod.outlook.com>
Date: Tue, 23 Sep 2025 16:17:07 +0000
From: <Don.Brace@...rochip.com>
To: <thorsten.blum@...ux.dev>, <James.Bottomley@...senPartnership.com>,
	<martin.petersen@...cle.com>
CC: <storagedev@...rochip.com>, <linux-scsi@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] scsi: smartpqi: Replace kmalloc + copy_from_user with
 memdup_user

________________________________________
From: Thorsten Blum <thorsten.blum@...ux.dev>
Sent: Monday, September 22, 2025 3:18 PM
To: Don Brace - C33706 <Don.Brace@...rochip.com>; James E.J. Bottomley <James.Bottomley@...senPartnership.com>; Martin K. Petersen <martin.petersen@...cle.com>
Cc: Thorsten Blum <thorsten.blum@...ux.dev>; storagedev <storagedev@...rochip.com>; linux-scsi@...r.kernel.org <linux-scsi@...r.kernel.org>; linux-kernel@...r.kernel.org <linux-kernel@...r.kernel.org>
Subject: [PATCH] scsi: smartpqi: Replace kmalloc + copy_from_user with memdup_user

EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe

Replace kmalloc() followed by copy_from_user() with memdup_user() to
simplify and improve pqi_passthru_ioctl().

Since memdup_user() already allocates memory, use kzalloc() in the else
branch instead of manually zeroing 'kernel_buffer' using memset(0).

Return early if an error occurs.  No functional changes intended.

Signed-off-by: Thorsten Blum <thorsten.blum@...ux.dev>
---

Acked-by: Don Brace <don.brace@...rochip.com>

Sorry about duplicate e-mail, forgot to switch to text-only.