linux-kernel - Re: [PATCH v2] lib/crypto: Add SHA3-224, SHA3-256, SHA3-384, SHA-512, SHAKE128, SHAKE256

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <530340.1758645078@warthog.procyon.org.uk>
Date: Tue, 23 Sep 2025 17:31:18 +0100
From: David Howells <dhowells@...hat.com>
To: Eric Biggers <ebiggers@...nel.org>
Cc: dhowells@...hat.com, "Jason A. Donenfeld" <Jason@...c4.com>,
    Ard Biesheuvel <ardb@...nel.org>,
    Harald Freudenberger <freude@...ux.ibm.com>,
    Holger Dengler <dengler@...ux.ibm.com>,
    Herbert Xu <herbert@...dor.apana.org.au>,
    Stephan Mueller <smueller@...onox.de>, Simo Sorce <simo@...hat.com>,
    linux-crypto@...r.kernel.org, linux-s390@...r.kernel.org,
    keyrings@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] lib/crypto: Add SHA3-224, SHA3-256, SHA3-384, SHA-512, SHAKE128, SHAKE256

David Howells <dhowells@...hat.com> wrote:

> Eric Biggers <ebiggers@...nel.org> wrote:
> 
> > > I assume that pertains to the comment about inlining in some way.  This
> > > is as is in sha3_generic.c.  I can move it into the round function if
> > > you like, but can you tell me what the effect will be?
> > 
> > The effect will be that the code will align more closely with how the
> > algorithm is described in the SHA-3 spec and other publications.
> 
> I meant on the code produced and the stack consumed.  It may align with other
> code, but if it runs off of the end of the stack then alignment is irrelevant.

See commit 4767b9ad7d762876a5865a06465e13e139a01b6b

"crypto: sha3-generic - deal with oversize stack frames"

For some reason (maybe Ard can comment on it), he left the Iota function out
of the keccakf_round() function.

David