linux-kernel - Re: [PATCH 2/2] tty: serial: imx: Add missing wakeup event reporting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202509240146.aj950Liu-lkp@intel.com>
Date: Wed, 24 Sep 2025 01:35:11 +0800
From: kernel test robot <lkp@...el.com>
To: Sherry Sun <sherry.sun@....com>, gregkh@...uxfoundation.org,
	jirislaby@...nel.org, shawnguo@...nel.org, s.hauer@...gutronix.de,
	kernel@...gutronix.de, festevam@...il.com, shenwei.wang@....com
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
	linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org,
	imx@...ts.linux.dev
Subject: Re: [PATCH 2/2] tty: serial: imx: Add missing wakeup event reporting

Hi Sherry,

kernel test robot noticed the following build errors:

[auto build test ERROR on shawnguo/for-next]
[also build test ERROR on usb/usb-testing usb/usb-next usb/usb-linus linus/master v6.17-rc7 next-20250922]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Sherry-Sun/tty-serial-imx-Only-configure-the-wake-register-when-device-is-set-as-wakeup-source/20250923-111951
base:   https://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git for-next
patch link:    https://lore.kernel.org/r/20250923031613.2448073-3-sherry.sun%40nxp.com
patch subject: [PATCH 2/2] tty: serial: imx: Add missing wakeup event reporting
config: x86_64-buildonly-randconfig-004-20250923 (https://download.01.org/0day-ci/archive/20250924/202509240146.aj950Liu-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250924/202509240146.aj950Liu-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202509240146.aj950Liu-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/tty/serial/imx.c:2742:21: error: call to undeclared function 'irqd_is_wakeup_set'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
    2742 |         if (wake_active && irqd_is_wakeup_set(irq_get_irq_data(sport->port.irq)))
         |                            ^
>> drivers/tty/serial/imx.c:2742:40: error: call to undeclared function 'irq_get_irq_data'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
    2742 |         if (wake_active && irqd_is_wakeup_set(irq_get_irq_data(sport->port.irq)))
         |                                               ^
   drivers/tty/serial/imx.c:2742:40: note: did you mean 'irq_set_irq_wake'?
   include/linux/interrupt.h:481:12: note: 'irq_set_irq_wake' declared here
     481 | extern int irq_set_irq_wake(unsigned int irq, unsigned int on);
         |            ^
   2 errors generated.


vim +/irqd_is_wakeup_set +2742 drivers/tty/serial/imx.c

  2696	
  2697	/* called with irq off */
  2698	static void imx_uart_enable_wakeup(struct imx_port *sport, bool on)
  2699	{
  2700		struct tty_port *port = &sport->port.state->port;
  2701		struct tty_struct *tty;
  2702		struct device *tty_dev;
  2703		u32 ucr3, usr1;
  2704		bool may_wake, wake_active;
  2705	
  2706		tty = tty_port_tty_get(port);
  2707		if (tty) {
  2708			tty_dev = tty->dev;
  2709			may_wake = tty_dev && device_may_wakeup(tty_dev);
  2710			tty_kref_put(tty);
  2711		}
  2712	
  2713		/* only configure the wake register when device set as wakeup source */
  2714		if (!may_wake)
  2715			return;
  2716	
  2717		uart_port_lock_irq(&sport->port);
  2718	
  2719		usr1 = imx_uart_readl(sport, USR1);
  2720		ucr3 = imx_uart_readl(sport, UCR3);
  2721		if (on) {
  2722			imx_uart_writel(sport, USR1_AWAKE, USR1);
  2723			ucr3 |= UCR3_AWAKEN;
  2724		} else {
  2725			ucr3 &= ~UCR3_AWAKEN;
  2726			wake_active = usr1 & USR1_AWAKE;
  2727		}
  2728		imx_uart_writel(sport, ucr3, UCR3);
  2729	
  2730		if (sport->have_rtscts) {
  2731			u32 ucr1 = imx_uart_readl(sport, UCR1);
  2732			if (on) {
  2733				imx_uart_writel(sport, USR1_RTSD, USR1);
  2734				ucr1 |= UCR1_RTSDEN;
  2735			} else {
  2736				ucr1 &= ~UCR1_RTSDEN;
  2737				wake_active |= usr1 & USR1_RTSD;
  2738			}
  2739			imx_uart_writel(sport, ucr1, UCR1);
  2740		}
  2741	
> 2742		if (wake_active && irqd_is_wakeup_set(irq_get_irq_data(sport->port.irq)))
  2743			pm_wakeup_event(tty_port_tty_get(port)->dev, 0);
  2744	
  2745		uart_port_unlock_irq(&sport->port);
  2746	}
  2747	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki