linux-kernel - Re: [PATCH v4] erofs: Add support for FS_IOC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <221cc0ee-60a7-4672-987b-cd80a5b13590@kernel.org>
Date: Tue, 23 Sep 2025 10:59:49 +0800
From: Chao Yu <chao@...nel.org>
To: Gao Xiang <hsiangkao@...ux.alibaba.com>, Bo Liu <liubo03@...pur.com>,
 xiang@...nel.org
Cc: chao@...nel.org, linux-erofs@...ts.ozlabs.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4] erofs: Add support for FS_IOC_GETFSLABEL

On 9/23/25 10:34, Gao Xiang wrote:
> Hi Chao,
> 
> On 2025/9/23 10:23, Chao Yu wrote:
>> On 9/22/25 17:29, Bo Liu wrote:
>>> From: Bo Liu (OpenAnolis) <liubo03@...pur.com>
>>>
>>> Add support for reading to the erofs volume label from the
>>> FS_IOC_GETFSLABEL ioctls.
>>>
>>> Signed-off-by: Bo Liu (OpenAnolis) <liubo03@...pur.com>
>>> ---
> 
> ...
> 
>>>   +long erofs_ioctl(struct file *filp, unsigned int cmd, unsigned long arg);
>>
>> #ifdef CONFIG_COMPAT
>>
>>> +long erofs_compat_ioctl(struct file *filp, unsigned int cmd,
>>> +            unsigned long arg);
> 
> Since it's a function declaration, when CONFIG_COMPAT is not defined,
> there is no user to use erofs_compat_ioctl(), so I think it is fine
> to just leave the declaration here?

Xiang,

Sure, it won't affect compile and link, we can leave it as it is since it's trivial.

Thanks,

> 
> Thanks,
> Gao Xiang
> 
>>
>> #endif
>>
>> Thanks,
>>
>>> +
>>
> 
>