| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <3e67c596-6002-4497-b8a5-70fba7c69e9d@linux.alibaba.com> Date: Tue, 23 Sep 2025 11:09:29 +0800 From: Gao Xiang <hsiangkao@...ux.alibaba.com> To: Chao Yu <chao@...nel.org>, Bo Liu <liubo03@...pur.com>, xiang@...nel.org Cc: linux-erofs@...ts.ozlabs.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH v4] erofs: Add support for FS_IOC_GETFSLABEL On 2025/9/23 10:59, Chao Yu wrote: > On 9/23/25 10:34, Gao Xiang wrote: >> Hi Chao, >> >> On 2025/9/23 10:23, Chao Yu wrote: >>> On 9/22/25 17:29, Bo Liu wrote: >>>> From: Bo Liu (OpenAnolis) <liubo03@...pur.com> >>>> >>>> Add support for reading to the erofs volume label from the >>>> FS_IOC_GETFSLABEL ioctls. >>>> >>>> Signed-off-by: Bo Liu (OpenAnolis) <liubo03@...pur.com> >>>> --- >> >> ... >> >>>> +long erofs_ioctl(struct file *filp, unsigned int cmd, unsigned long arg); >>> >>> #ifdef CONFIG_COMPAT >>> >>>> +long erofs_compat_ioctl(struct file *filp, unsigned int cmd, >>>> + unsigned long arg); >> >> Since it's a function declaration, when CONFIG_COMPAT is not defined, >> there is no user to use erofs_compat_ioctl(), so I think it is fine >> to just leave the declaration here? > > Xiang, > > Sure, it won't affect compile and link, we can leave it as it is since it's trivial. Yeah, my preference is to avoid unnecessary #ifdef if possible, anyway (since unused function declarations won't affect anything..) Thanks, Gao Xiang > > Thanks, > >> >> Thanks, >> Gao Xiang >> >>> >>> #endif >>> >>> Thanks, >>> >>>> + >>> >> >>
Powered by blists - more mailing lists