| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20250923174752.35701-10-shivankg@amd.com>
Date: Tue, 23 Sep 2025 17:47:44 +0000
From: Shivank Garg <shivankg@....com>
To: <akpm@...ux-foundation.org>, <david@...hat.com>
CC: <ziy@...dia.com>, <willy@...radead.org>, <matthew.brost@...el.com>,
<joshua.hahnjy@...il.com>, <rakie.kim@...com>, <byungchul@...com>,
<gourry@...rry.net>, <ying.huang@...ux.alibaba.com>, <apopple@...dia.com>,
<lorenzo.stoakes@...cle.com>, <Liam.Howlett@...cle.com>, <vbabka@...e.cz>,
<rppt@...nel.org>, <surenb@...gle.com>, <mhocko@...e.com>,
<vkoul@...nel.org>, <lucas.demarchi@...el.com>, <rdunlap@...radead.org>,
<jgg@...pe.ca>, <kuba@...nel.org>, <justonli@...omium.org>,
<ivecera@...hat.com>, <dave.jiang@...el.com>, <Jonathan.Cameron@...wei.com>,
<dan.j.williams@...el.com>, <rientjes@...gle.com>,
<Raghavendra.KodsaraThimmappa@....com>, <bharata@....com>,
<shivankg@....com>, <alirad.malek@...corp.com>, <yiannis@...corp.com>,
<weixugc@...gle.com>, <linux-kernel@...r.kernel.org>, <linux-mm@...ck.org>
Subject: [RFC V3 9/9] mtcopy: spread threads across die for testing
Select CPUs using sysfs
For testing purpose only.
Signed-off-by: Shivank Garg <shivankg@....com>
---
drivers/migoffcopy/mtcopy/copy_pages.c | 76 +++++++++++++++++++++++++-
1 file changed, 73 insertions(+), 3 deletions(-)
diff --git a/drivers/migoffcopy/mtcopy/copy_pages.c b/drivers/migoffcopy/mtcopy/copy_pages.c
index 68e50de602d6..e605acca39d0 100644
--- a/drivers/migoffcopy/mtcopy/copy_pages.c
+++ b/drivers/migoffcopy/mtcopy/copy_pages.c
@@ -15,11 +15,37 @@
#include <linux/migrate.h>
#include <linux/migrate_offc.h>
-#define MAX_NUM_COPY_THREADS 64
+#define MAX_NUM_COPY_THREADS 32
unsigned int limit_mt_num = 4;
static int is_dispatching;
+static int cpuselect;
+
+// spread across die
+static const int cpu_id_list_0[] = {
+ 0, 8, 16, 24,
+ 32, 40, 48, 56,
+ 64, 72, 80, 88,
+ 96, 104, 112, 120,
+ 128, 136, 144, 152,
+ 160, 168, 176, 184,
+ 192, 200, 208, 216,
+ 224, 232, 240, 248};
+
+// don't spread, fill the die
+static const int cpu_id_list_1[] = {
+ 0, 1, 2, 3,
+ 4, 5, 6, 7,
+ 8, 9, 10, 11,
+ 12, 13, 14, 15,
+ 16, 17, 18, 19,
+ 20, 21, 22, 23,
+ 24, 25, 26, 27,
+ 28, 29, 30, 31};
+
+int cpu_id_list[32] = {0};
+
static int copy_page_lists_mt(struct list_head *dst_folios,
struct list_head *src_folios, unsigned int nr_items);
@@ -141,6 +167,39 @@ static ssize_t mt_threads_show(struct kobject *kobj,
return sysfs_emit(buf, "%u\n", limit_mt_num);
}
+static ssize_t mt_cpuselect_set(struct kobject *kobj, struct kobj_attribute *attr,
+ const char *buf, size_t count)
+{
+ int ccode;
+ unsigned int cpuconfig;
+
+ ccode = kstrtouint(buf, 0, &cpuconfig);
+ if (ccode) {
+ pr_debug("(%s:) error parsing input %s\n", __func__, buf);
+ return ccode;
+ }
+ mutex_lock(&migratecfg_mutex);
+ cpuselect = cpuconfig;
+ switch (cpuselect) {
+ case 1:
+ memcpy(cpu_id_list, cpu_id_list_1, MAX_NUM_COPY_THREADS*sizeof(int));
+ break;
+ default:
+ memcpy(cpu_id_list, cpu_id_list_0, MAX_NUM_COPY_THREADS*sizeof(int));
+ break;
+ }
+
+ mutex_unlock(&migratecfg_mutex);
+
+ return count;
+}
+
+static ssize_t mt_cpuselect_show(struct kobject *kobj,
+ struct kobj_attribute *attr, char *buf)
+{
+ return sysfs_emit(buf, "%u\n", cpuselect);
+}
+
int copy_page_lists_mt(struct list_head *dst_folios,
struct list_head *src_folios, unsigned int nr_items)
{
@@ -208,7 +267,7 @@ int copy_page_lists_mt(struct list_head *dst_folios,
}
for (cpu = 0; cpu < total_mt_num; ++cpu)
- queue_work(system_unbound_wq,
+ queue_work_on(cpu_id_list[cpu], system_unbound_wq,
(struct work_struct *)work_items[cpu]);
} else {
int num_xfer_per_thread = nr_items / total_mt_num;
@@ -245,7 +304,7 @@ int copy_page_lists_mt(struct list_head *dst_folios,
dst2 = list_next_entry(dst, lru);
if (per_cpu_item_idx == work_items[cpu]->num_items) {
- queue_work(system_unbound_wq,
+ queue_work_on(cpu_id_list[cpu], system_unbound_wq,
(struct work_struct *)work_items[cpu]);
per_cpu_item_idx = 0;
cpu++;
@@ -276,6 +335,8 @@ static struct kobj_attribute mt_offloading_attribute = __ATTR(offloading, 0664,
mt_offloading_show, mt_offloading_set);
static struct kobj_attribute mt_threads_attribute = __ATTR(threads, 0664,
mt_threads_show, mt_threads_set);
+static struct kobj_attribute mt_cpuselect_attribute = __ATTR(cpuselect, 0664,
+ mt_cpuselect_show, mt_cpuselect_set);
static int __init cpu_mt_module_init(void)
{
@@ -293,10 +354,18 @@ static int __init cpu_mt_module_init(void)
if (ret)
goto out_threads;
+ ret = sysfs_create_file(mt_kobj_ref, &mt_cpuselect_attribute.attr);
+ if (ret)
+ goto out_cpuselect;
+
+ memcpy(cpu_id_list, cpu_id_list_0, MAX_NUM_COPY_THREADS*sizeof(int));
+
is_dispatching = 0;
return 0;
+out_cpuselect:
+ sysfs_remove_file(mt_kobj_ref, &mt_threads_attribute.attr);
out_threads:
sysfs_remove_file(mt_kobj_ref, &mt_offloading_attribute.attr);
out_offloading:
@@ -314,6 +383,7 @@ static void __exit cpu_mt_module_exit(void)
}
mutex_unlock(&migratecfg_mutex);
+ sysfs_remove_file(mt_kobj_ref, &mt_cpuselect_attribute.attr);
sysfs_remove_file(mt_kobj_ref, &mt_threads_attribute.attr);
sysfs_remove_file(mt_kobj_ref, &mt_offloading_attribute.attr);
kobject_put(mt_kobj_ref);
--
2.43.0
Powered by blists - more mailing lists