linux-kernel - Re: [PATCH v1 3/3] scsi: ufs: core: Add OP-TEE based RPMB driver for UFS devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b2ed97b4-bfef-4e4b-83ed-a172214e46e8@acm.org>
Date: Tue, 23 Sep 2025 13:27:45 -0700
From: Bart Van Assche <bvanassche@....org>
To: Bean Huo <beanhuo@...pp.de>, avri.altman@....com,
 alim.akhtar@...sung.com, jejb@...ux.ibm.com, martin.petersen@...cle.com,
 can.guo@....qualcomm.com, ulf.hansson@...aro.org, beanhuo@...ron.com,
 jens.wiklander@...aro.org
Cc: linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 3/3] scsi: ufs: core: Add OP-TEE based RPMB driver for
 UFS devices

On 9/23/25 8:39 AM, Bean Huo wrote:
> +	ret = scsi_execute_cmd(sdev, cdb, send ? REQ_OP_DRV_OUT : REQ_OP_DRV_IN,
> +	                       buffer, len,  /*timeout=*/30 * HZ, 0, NULL);
> +	return ret <= 0 ? ret : -EIO;

scsi_execute_cmd() can return a negative value, zero, or a positive
value. Both negative and positive values should be considered as an
error.

> +MODULE_DESCRIPTION("UFS RPMB integration into the RPMB framework using SCSI Secure In/Out");

That's a very long module description ... Can this description be made
shorter without reducing clarity?

> +	u8 rpmb_region0_size;
> +	u8 rpmb_region1_size;
> +	u8 rpmb_region2_size;
> +	u8 rpmb_region3_size;

Why four separate members instead of an array?

Thanks,

Bart.