linux-kernel - Re: [PATCH v1 1/3] rpmb: move rpmb_frame struct and constants to common header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a41bd12c-37c8-46d0-9fe3-c9ef0ca7cd95@acm.org>
Date: Tue, 23 Sep 2025 13:28:40 -0700
From: Bart Van Assche <bvanassche@....org>
To: Bean Huo <beanhuo@...pp.de>, avri.altman@....com,
 alim.akhtar@...sung.com, jejb@...ux.ibm.com, martin.petersen@...cle.com,
 can.guo@....qualcomm.com, ulf.hansson@...aro.org, beanhuo@...ron.com,
 jens.wiklander@...aro.org
Cc: linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 1/3] rpmb: move rpmb_frame struct and constants to
 common header

On 9/23/25 8:39 AM, Bean Huo wrote:
> +struct rpmb_frame {
> +	u8     stuff[196];
> +	u8     key_mac[32];
> +	u8     data[256];
> +	u8     nonce[16];
> +	__be32 write_counter	__packed;
> +	__be16 addr		__packed;
> +	__be16 block_count	__packed;
> +	__be16 result		__packed;
> +	__be16 req_resp		__packed;
> +};

I think that it is safe to remove __packed from the above structure
members since the size of the first four members is a multiple of four
(196 + 32 + 256 + 16) and that is sufficient not to introduce any gaps
between the __be* members.

Thanks,

Bart.