linux-kernel - Re: [PATCH 2/9] dt-bindings: phy: qcom,qmp-usb: Add Glymur USB UNI PHY compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aNJL1YEXx6IabTos@hovoldconsulting.com>
Date: Tue, 23 Sep 2025 09:27:17 +0200
From: Johan Hovold <johan@...nel.org>
To: Wesley Cheng <wesley.cheng@....qualcomm.com>
Cc: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>,
	krzk+dt@...nel.org, conor+dt@...nel.org, kishon@...nel.org,
	vkoul@...nel.org, gregkh@...uxfoundation.org, robh@...nel.org,
	linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
	devicetree@...r.kernel.org, linux-usb@...r.kernel.org,
	linux-phy@...ts.infradead.org
Subject: Re: [PATCH 2/9] dt-bindings: phy: qcom,qmp-usb: Add Glymur USB UNI
 PHY compatible

On Mon, Sep 22, 2025 at 06:00:04PM -0700, Wesley Cheng wrote:
> 
> 
> On 9/20/2025 8:22 AM, Dmitry Baryshkov wrote:
> > On Fri, Sep 19, 2025 at 08:21:01PM -0700, Wesley Cheng wrote:
> >> The Glymur USB subsystem contains a multiport controller, which utilizes
>
>> two QMP UNI PHYs.  Add the proper compatible string for the Glymur SoC.
> >> @@ -16,6 +16,7 @@ description:
> >>   properties:
> >>     compatible:
> >>       enum:
> >> +      - qcom,glymur-qmp-usb3-uni-phy

Odd indentation?

> >>         - qcom,ipq5424-qmp-usb3-phy
> >>         - qcom,ipq6018-qmp-usb3-phy
> >>         - qcom,ipq8074-qmp-usb3-phy
> >> @@ -62,6 +63,8 @@ properties:
> >>   
> >>     vdda-pll-supply: true
> >>   
> >> +  refgen-supply: true
> > 
> > You've added it, but it's not referenced as required. Why is it so?

> The refgen clock isn't always required on each and every platform unlike 
> the .9v and 1.2v rail/supply, which directly power the QMP PHY.  It only 
> really depends on how the refclk/CXO network is built for that 
> particular chipset.  The refgen ensures that we're properly voting for 
> the supply that is powering our CXO buffer.

I thought we discussed this before and concluded that this is not an
accurate description of the hardware (even if you now call this supply
refgen instead of qref):

	https://lore.kernel.org/lkml/aEBfV2M-ZqDF7aRz@hovoldconsulting.com/

Given your description above this still looks wrong (at least after a
quick look).

Johan