linux-kernel - Re: [PATCH v5 3/4] leds: led-class: Add devicetree support to led

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <L7z33cG0mE3y_WEFhvHRJ-wbjg2kxIBVMV0C9qCifJx1DTAyMYyokyKWErFXEuzra3Kjt4pcUZ1VtzRWLBbKVNewDvJtyqPdcHMXUp4h0G0=@vinarskis.com>
Date: Tue, 23 Sep 2025 08:36:08 +0000
From: Aleksandrs Vinarskis <alex@...arskis.com>
To: Lee Jones <lee@...nel.org>
Cc: Bjorn Andersson <andersson@...nel.org>, Hans de Goede <hansg@...nel.org>, Pavel Machek <pavel@...nel.org>, Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, Bryan O'Donoghue <bryan.odonoghue@...aro.org>, Jingoo Han <jingoohan1@...il.com>, Mauro Carvalho Chehab <mchehab@...nel.org>, Jean-Jacques Hiblot <jjhiblot@...phandler.com>, Jacopo Mondi <jacopo@...ndi.org>, Sakari Ailus <sakari.ailus@...ux.intel.com>, Konrad Dybcio <konradybcio@...nel.org>, Daniel Thompson <danielt@...nel.org>, linux-leds@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org, linux-media@...r.kernel.org, linux-arm-msm@...r.kernel.org, threeway@...il.com, Andy Shevchenko <andy.shevchenko@...il.com>, Linus Walleij <linus.walleij@...aro.org>
Subject: Re: [PATCH v5 3/4] leds: led-class: Add devicetree support to led_get()






On Tuesday, September 16th, 2025 at 18:07, Lee Jones <lee@...nel.org> wrote:

> 
> 
> On Tue, 16 Sep 2025, Bjorn Andersson wrote:
> 
> > On Thu, Sep 11, 2025 at 11:01:00AM +0200, Hans de Goede wrote:
> > 
> > > Hi Lee,
> > > 
> > > On 11-Sep-25 10:15 AM, Lee Jones wrote:
> > > 
> > > > On Wed, 10 Sep 2025, Aleksandrs Vinarskis wrote:
> > > > 
> > > > > From: Hans de Goede hansg@...nel.org
> > > > > 
> > > > > Add 'name' argument to of_led_get() such that it can lookup LEDs in
> > > > > devicetree by either name or index.
> > > > > 
> > > > > And use this modified function to add devicetree support to the generic
> > > > > (non devicetree specific) [devm_]led_get() function.
> > > > > 
> > > > > This uses the standard devicetree pattern of adding a -names string array
> > > > > to map names to the indexes for an array of resources.
> > > > > 
> > > > > Reviewed-by: Andy Shevchenko andy.shevchenko@...il.com
> > > > > Reviewed-by: Lee Jones lee@...nel.org
> > > > 
> > > > Remind me why this can't go in through LED again?
> > > 
> > > I don't think anyone has discussed how to merge this yet.
> > > 
> > > I believe that the LED tree is the correct tree to merge this
> > > entire series through, once the DT bits have been reviewed.
> > 
> > Unless there are some strong reasons (that I'm failing to spot), we
> > should merge the DeviceTree binding and implementation through the LED
> > tree. Then I merge the DTS change through the Qualcomm DT tree once the
> > bindings are available in linux-next.

Hi Bjorn,

The bindings are now in linux-next. Could you please pick the DTS change?

Thanks,
Alex

> 
> 
> 1-3 have been applied to the LED tree already.
> 
> --
> Lee Jones [李琼斯]