linux-kernel - Re: [PATCH 0/4] Add CAMSS support for MSM8939

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <14e75b6ebc3e558d3449f8b4043d31260bfaffc4.camel@apitzsch.eu>
Date: Tue, 23 Sep 2025 12:27:41 +0200
From: André Apitzsch <git@...tzsch.eu>
To: Bryan O'Donoghue <bryan.odonoghue@...aro.org>, Robert Foss	
 <rfoss@...nel.org>, Todor Tomov <todor.too@...il.com>, Vladimir Zapolskiy	
 <vladimir.zapolskiy@...aro.org>, Mauro Carvalho Chehab
 <mchehab@...nel.org>,  Rob Herring <robh@...nel.org>, Krzysztof Kozlowski
 <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,  Bjorn Andersson
 <andersson@...nel.org>, Konrad Dybcio <konradybcio@...nel.org>
Cc: ~postmarketos/upstreaming@...ts.sr.ht, phone-devel@...r.kernel.org, 
	linux-media@...r.kernel.org, linux-arm-msm@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, Vincent Knecht
	 <vincent.knecht@...loo.org>
Subject: Re: [PATCH 0/4] Add CAMSS support for MSM8939

Hi,

Am Montag, dem 08.09.2025 um 11:56 +0100 schrieb Bryan O'Donoghue:
> On 07/09/2025 23:04, André Apitzsch via B4 Relay wrote:
> > (This series resumes [1].)
> > 
> > This series adds CAMSS support for MSM8939.  It's mostly identical
> > to
> > MSM8916, except for some clocks and an additional CSI.
> > 
> > To fix black stripes across sensor output, and garbage in CSID TPG
> > output, 2 VFE VBIF register settings are needed.  So the 2nd patch
> > adds
> > helper functions to do just that.
> > 
> > Patch 1: documents qcom,msm8939-camss DT bindings
> > Patch 2: adds helper for VFE VBIF settings
> > Patch 3: adds CAMSS_8x39 version in CAMSS driver
> > Patch 4: adds camss and cci in msm8939.dtsi
> > 
> > Changes compared to [1]:
> > - Move bindings patch to the beginning
> > - Make the order of {reg, clock, interrupt} items the same as in
> > 8916 +
> >    append additional items
> > - Drop R-b tags from bindings and dts patches as order of items was
> >    changed
> > 
> > [1]
> > https://lore.kernel.org/all/20250613-camss-8x39-vbif-v5-0-a002301a7730@mailoo.org/
> > 
> > Signed-off-by: Vincent Knecht <vincent.knecht@...loo.org>
> > [André: Apply reviewer comments]
> > Signed-off-by: André Apitzsch <git@...tzsch.eu>
> > ---
> > Vincent Knecht (4):
> >        media: dt-bindings: Add qcom,msm8939-camss
> >        media: qcom: camss: vfe: Add VBIF setting support
> >        media: qcom: camss: Add support for MSM8939
> >        arm64: dts: qcom: msm8939: Add camss and cci
> > 
> >   .../bindings/media/qcom,msm8939-camss.yaml         | 254
> > +++++++++++++++++++++
> >   arch/arm64/boot/dts/qcom/msm8939-pm8916.dtsi       |   4 +
> >   arch/arm64/boot/dts/qcom/msm8939.dtsi              | 146
> > ++++++++++++
> >   drivers/media/platform/qcom/camss/Makefile         |   1 +
> >   drivers/media/platform/qcom/camss/camss-csiphy.c   |   1 +
> >   drivers/media/platform/qcom/camss/camss-ispif.c    |   8 +-
> >   drivers/media/platform/qcom/camss/camss-vfe-4-1.c  |  12 +
> >   drivers/media/platform/qcom/camss/camss-vfe-vbif.c |  31 +++
> >   drivers/media/platform/qcom/camss/camss-vfe-vbif.h |  19 ++
> >   drivers/media/platform/qcom/camss/camss-vfe.c      |  10 +
> >   drivers/media/platform/qcom/camss/camss-vfe.h      |   3 +
> >   drivers/media/platform/qcom/camss/camss.c          | 157
> > +++++++++++++
> >   drivers/media/platform/qcom/camss/camss.h          |   1 +
> >   13 files changed, 645 insertions(+), 2 deletions(-)
> > ---
> > base-commit: be5d4872e528796df9d7425f2bd9b3893eb3a42c
> > change-id: 20250517-camss-8x39-vbif-975ff5819198
> > 
> > Best regards,
> 
> Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@...aro.org>

any chance, this series can be applied for the next merge window?

Best regards,
André