lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <12748135.O9o76ZdvQC@7940hx>
Date: Tue, 23 Sep 2025 18:27:30 +0800
From: menglong.dong@...ux.dev
To: Steven Rostedt <rostedt@...dmis.org>
Cc: mhiramat@...nel.org, mathieu.desnoyers@...icios.com,
 linux-kernel@...r.kernel.org, linux-trace-kernel@...r.kernel.org,
 bpf@...r.kernel.org
Subject:
 Re: [PATCH 1/2] tracing: fprobe: rename fprobe_entry to fprobe_fgraph_entry

On 2025/9/23 17:38 Steven Rostedt <rostedt@...dmis.org> write:
> On Tue, 23 Sep 2025 17:20:00 +0800
> Menglong Dong <menglong8.dong@...il.com> wrote:
> 
> > The fprobe_entry() is used by fgraph_ops, so rename it to
> > fprobe_fgraph_entry to be more distinctive.
> 
> The change log should be more specific and state that this will allow
> to have fprobes to use ftrace too. I didn't know why you did this until
> I saw the second patch. As change logs should be self contain, it
> should have enough information to not rely on knowing other commits to
> understand why the patch is made.

Ah, you are right, the commit log of this patch is too simple.
I'll add enough information on what it is for in the next version.

Thanks!
Menglong Dong

> 
> -- Steve
> 
> 





Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ