linux-kernel - Re: [PATCH 1/2] media: iris: Add support for QC08C format for decoder

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b3c3a9b47a2075f6a0acc1ee501f885d4997679e.camel@ndufresne.ca>
Date: Wed, 24 Sep 2025 11:50:28 -0400
From: Nicolas Dufresne <nicolas@...fresne.ca>
To: Markus Elfring <Markus.Elfring@....de>, Dikshita Agarwal
	 <dikshita.agarwal@....qualcomm.com>, linux-media@...r.kernel.org, 
	linux-arm-msm@...r.kernel.org
Cc: LKML <linux-kernel@...r.kernel.org>, Abhinav Kumar
 <abhinav.kumar@...ux.dev>,  Bryan O'Donoghue	 <bod@...nel.org>, Mauro
 Carvalho Chehab <mchehab@...nel.org>, Vikash Garodia	
 <vikash.garodia@....qualcomm.com>
Subject: Re: [PATCH 1/2] media: iris: Add support for QC08C format for
 decoder

Hi,

Le mercredi 24 septembre 2025 à 14:32 +0200, Markus Elfring a écrit :
> …
> > +++ b/drivers/media/platform/qcom/iris/iris_buffer.c
> > @@ -261,7 +261,10 @@ int iris_get_buffer_size(struct iris_inst *inst,
> >  		case BUF_INPUT:
> >  			return iris_dec_bitstream_buffer_size(inst);
> >  		case BUF_OUTPUT:
> > -			return iris_yuv_buffer_size_nv12(inst);
> > +			if (inst->fmt_dst->fmt.pix_mp.pixelformat ==
> > V4L2_PIX_FMT_QC08C)
> > +				return iris_yuv_buffer_size_qc08c(inst);
> > +			else
> > +				return iris_yuv_buffer_size_nv12(inst);
> …
> 
> How do you think about to use a source code variant like the following?
> 
> 			return (inst->fmt_dst->fmt.pix_mp.pixelformat ==
> V4L2_PIX_FMT_QC08C)
> 				? iris_yuv_buffer_size_qc08c(inst)
> 				: iris_yuv_buffer_size_nv12(inst);

Please don't, this is less readable and have no explained technical advantages.

Nicolas

> 
> 
> Regards,
> Markus

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)