linux-kernel - Re: [PATCH 2/2] media: iris: Add support for QC08C format for encoder

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <908fece9-769b-4f44-86bb-04de7c3d510e@kernel.org>
Date: Wed, 24 Sep 2025 14:31:41 +0100
From: Bryan O'Donoghue <bod@...nel.org>
To: Markus Elfring <Markus.Elfring@....de>,
 Dikshita Agarwal <dikshita.agarwal@....qualcomm.com>,
 linux-media@...r.kernel.org, linux-arm-msm@...r.kernel.org
Cc: LKML <linux-kernel@...r.kernel.org>,
 Abhinav Kumar <abhinav.kumar@...ux.dev>,
 Mauro Carvalho Chehab <mchehab@...nel.org>,
 Vikash Garodia <vikash.garodia@....qualcomm.com>
Subject: Re: [PATCH 2/2] media: iris: Add support for QC08C format for encoder

On 24/09/2025 13:40, Markus Elfring wrote:
> …
>> +++ b/drivers/media/platform/qcom/iris/iris_buffer.c
>> @@ -171,9 +171,14 @@ static u32 iris_yuv_buffer_size_nv12(struct iris_inst *inst)
>>   static u32 iris_yuv_buffer_size_qc08c(struct iris_inst *inst)
>>   {
>>   	u32 y_plane, uv_plane, y_stride, uv_stride;
>> -	struct v4l2_format *f = inst->fmt_dst;
>>   	u32 uv_meta_stride, uv_meta_plane;
>>   	u32 y_meta_stride, y_meta_plane;
>> +	struct v4l2_format *f = NULL;
>> +
>> +	if (inst->domain == DECODER)
>> +		f = inst->fmt_dst;
>> +	else
>> +		f = inst->fmt_src;
> …
> 
> How do you think about to use a source code variant like the following?
> 
> 	struct v4l2_format *f = (inst->domain == DECODER) ? inst->fmt_dst : inst->fmt_src;
> 
> 
> Regards,
> Markus

My personal preference is for if / else as above.

Trying to encourage the Iris people to move away from ternary operators ...

---
bod