linux-kernel - Re: [PATCH 00/17] USB/IP VHCI driver cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <eb86ebd0-71ff-4c00-a524-0046b86b3aa6@linuxfoundation.org>
Date: Wed, 24 Sep 2025 14:44:07 -0600
From: Shuah Khan <skhan@...uxfoundation.org>
To: Cristian Ciocaltea <cristian.ciocaltea@...labora.com>,
 Valentina Manea <valentina.manea.m@...il.com>, Shuah Khan
 <shuah@...nel.org>, Hongren Zheng <i@...ithal.me>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: kernel@...labora.com, linux-usb@...r.kernel.org,
 linux-kernel@...r.kernel.org, Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH 00/17] USB/IP VHCI driver cleanup

On 9/2/25 05:56, Cristian Ciocaltea wrote:
> These patches were initially part of the USB/IP VHCI suspend fix series
> [1] to address a bunch of coding style issues and make checkpatch happy
> for the entire driver.
> 
> As suggested by Greg, I'm sending this as a separate patch set now.
> 
> [1] https://lore.kernel.org/r/20250726-vhci-hcd-suspend-fix-v2-0-189266dfdfaa@collabora.com
> 
> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@...labora.com>
> ---
> Cristian Ciocaltea (17):
>        usb: vhci-hcd: Ensure lines do not end with '('
>        usb: vhci-hcd: Consistently use the braces
>        usb: vhci-hcd: Avoid unnecessary use of braces
>        usb: vhci-hcd: Consistently use blank lines
>        usb: vhci-hcd: Drop spaces after casts
>        usb: vhci-hcd: Add spaces around operators
>        usb: vhci-hcd: Drop unnecessary parentheses
>        usb: vhci-hcd: Fix open parenthesis alignment
>        usb: vhci-hcd: Simplify NULL comparison
>        usb: vhci-hcd: Simplify kzalloc usage
>        usb: vhci-hcd: Use the paranthesized form of sizeof
>        usb: vhci-hcd: Fix block comments
>        usb: vhci-hcd: Remove ftrace-like logging
>        usb: vhci-hcd: Consistently use __func__
>        usb: vhci-hcd: Do not split quoted strings

>        usb: vhci-hcd: Switch to dev_err_probe() in probe path
>        usb: vhci-hcd: Replace pr_*() with dev_*() logging

I acked the 16/17 and 17/17 - others I don't see a reason for code
churn.

thanks,
-- Shuah