linux-kernel - Re: [PATCH 00/17] USB/IP VHCI driver cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2025100839-lent-smother-9527@gregkh>
Date: Wed, 8 Oct 2025 13:00:04 +0200
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Shuah Khan <skhan@...uxfoundation.org>
Cc: Cristian Ciocaltea <cristian.ciocaltea@...labora.com>,
	Valentina Manea <valentina.manea.m@...il.com>,
	Shuah Khan <shuah@...nel.org>, Hongren Zheng <i@...ithal.me>,
	kernel@...labora.com, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 00/17] USB/IP VHCI driver cleanup

On Wed, Sep 24, 2025 at 02:44:07PM -0600, Shuah Khan wrote:
> On 9/2/25 05:56, Cristian Ciocaltea wrote:
> > These patches were initially part of the USB/IP VHCI suspend fix series
> > [1] to address a bunch of coding style issues and make checkpatch happy
> > for the entire driver.
> > 
> > As suggested by Greg, I'm sending this as a separate patch set now.
> > 
> > [1] https://lore.kernel.org/r/20250726-vhci-hcd-suspend-fix-v2-0-189266dfdfaa@collabora.com
> > 
> > Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@...labora.com>
> > ---
> > Cristian Ciocaltea (17):
> >        usb: vhci-hcd: Ensure lines do not end with '('
> >        usb: vhci-hcd: Consistently use the braces
> >        usb: vhci-hcd: Avoid unnecessary use of braces
> >        usb: vhci-hcd: Consistently use blank lines
> >        usb: vhci-hcd: Drop spaces after casts
> >        usb: vhci-hcd: Add spaces around operators
> >        usb: vhci-hcd: Drop unnecessary parentheses
> >        usb: vhci-hcd: Fix open parenthesis alignment
> >        usb: vhci-hcd: Simplify NULL comparison
> >        usb: vhci-hcd: Simplify kzalloc usage
> >        usb: vhci-hcd: Use the paranthesized form of sizeof
> >        usb: vhci-hcd: Fix block comments
> >        usb: vhci-hcd: Remove ftrace-like logging
> >        usb: vhci-hcd: Consistently use __func__
> >        usb: vhci-hcd: Do not split quoted strings
> 
> >        usb: vhci-hcd: Switch to dev_err_probe() in probe path
> >        usb: vhci-hcd: Replace pr_*() with dev_*() logging
> 
> I acked the 16/17 and 17/17 - others I don't see a reason for code
> churn.

Great!  Christian, can you resend just those two patches as a series
with Shuah's ack on them for me to pick up?

thanks,

greg k-h