linux-kernel - Re: [PATCH net-next v11 5/5] net: dsa: yt921x: Add support for Motorcomm YT921x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250923174737.4759aaf4@kernel.org>
Date: Tue, 23 Sep 2025 17:47:37 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: David Yang <mmyangfl@...il.com>
Cc: netdev@...r.kernel.org, Andrew Lunn <andrew@...n.ch>, Vladimir Oltean
 <olteanv@...il.com>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Rob Herring
 <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Heiner Kallweit <hkallweit1@...il.com>, Russell King
 <linux@...linux.org.uk>, Simon Horman <horms@...nel.org>,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v11 5/5] net: dsa: yt921x: Add support for
 Motorcomm YT921x

On Mon, 22 Sep 2025 21:11:43 +0800 David Yang wrote:
> +	MIB_DESC(1, 0x00, "RxBroadcast", false),	/* rx broadcast pkts */
> +	MIB_DESC(1, 0x04, "RxPause", false),		/* rx pause pkts */
> +	MIB_DESC(1, 0x08, "RxMulticast", false),	/* rx multicast pkts, excluding pause and OAM */
> +	MIB_DESC(1, 0x0c, "RxCrcErr", false),		/* rx crc err pkts, len >= 64B */

Keeping the string names for every stat, and the boolean seems like 
an overkill when there is grand total of 3 stats that set "true".
The comments for IEEE stats can also go, there's no extra information
here.

> +static void yt921x_mdio_remove(struct mdio_device *mdiodev)
> +{

> +		cancel_delayed_work_sync(&pp->mib_read);
> +	}
> +
> +	dsa_unregister_switch(&priv->ds);

The work canceling looks racy, the port can come up in between
cancel_work and dsa_unregister ? disable_delayed_work.. will likely 
do the job.
-- 
pw-bot: cr