linux-kernel - Re: [PATCH 1/2] dt-bindings: clock: airoha: Add reset support to EN7523 clock binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9dd2fea8-f828-4298-97a2-10ef1c61799f@collabora.com>
Date: Wed, 24 Sep 2025 10:27:05 +0200
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
To: Mikhail Kshevetskiy <mikhail.kshevetskiy@...sys.eu>,
 Michael Turquette <mturquette@...libre.com>, Stephen Boyd
 <sboyd@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Matthias Brugger <matthias.bgg@...il.com>,
 Philipp Zabel <p.zabel@...gutronix.de>, Felix Fietkau <nbd@....name>,
 linux-clk@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-mediatek@...ts.infradead.org
Cc: Andreas Gnau <andreas.gnau@...sys.eu>
Subject: Re: [PATCH 1/2] dt-bindings: clock: airoha: Add reset support to
 EN7523 clock binding

Il 24/09/25 08:05, Mikhail Kshevetskiy ha scritto:
> Introduce reset capability to EN7523 device-tree clock binding
> documentation. Also this patch makes mandatory '#reset-cells'
> property for EN7523 SoC dts.
> 
> Signed-off-by: Mikhail Kshevetskiy <mikhail.kshevetskiy@...sys.eu>
> ---
>   .../bindings/clock/airoha,en7523-scu.yaml     |  4 +-
>   .../dt-bindings/reset/airoha,en7523-reset.h   | 61 +++++++++++++++++++
>   2 files changed, 63 insertions(+), 2 deletions(-)
>   create mode 100644 include/dt-bindings/reset/airoha,en7523-reset.h
> 
> diff --git a/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml b/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml
> index fe2c5c1baf43..a0df16485300 100644
> --- a/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml
> +++ b/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml
> @@ -53,6 +53,7 @@ required:
>     - compatible
>     - reg
>     - '#clock-cells'
> +  - '#reset-cells'

I can't find any reason why #reset-cells should be a required property: this is a
clock controller, it doesn't necessarily have to provide resets, and you don't
necessarily have to use resets, so this shall not be a required property.


>   
>   allOf:
>     - if:
> @@ -64,8 +65,6 @@ allOf:
>           reg:
>             minItems: 2
>   
> -        '#reset-cells': false
> -
>     - if:
>         properties:
>           compatible:
> @@ -85,6 +84,7 @@ examples:
>         reg = <0x1fa20000 0x400>,
>               <0x1fb00000 0x1000>;
>         #clock-cells = <1>;
> +      #reset-cells = <1>;
>       };
>   
>     - |

Regards,
Angelo