linux-kernel - Re: [PATCH v2 0/2] Add device tree for ASRock Rack ALTRAD8 BMC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9990f63e533c538ca95c3a2bd3401d27f031c330.camel@codeconstruct.com.au>
Date: Wed, 24 Sep 2025 11:43:30 +0930
From: Andrew Jeffery <andrew@...econstruct.com.au>
To: Rebecca Cran <rebecca@...io.com>, Rob Herring <robh@...nel.org>, 
 Krzysztof Kozlowski
	 <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, Joel Stanley
	 <joel@....id.au>, devicetree@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org, linux-aspeed@...ts.ozlabs.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/2] Add device tree for ASRock Rack ALTRAD8 BMC

Hi Rebecca,

On Mon, 2025-09-22 at 14:47 -0600, Rebecca Cran wrote:
> On 9/21/25 20:40, Andrew Jeffery wrote:
> 
> > On Wed, 2025-09-17 at 12:04 -0600, Rebecca Cran wrote:
> > > aspeed-bmc-asrock-altrad8.dts:578.16-581.6: Warning (unique_unit_address_if_enabled): /ahb/spi@...30000/flash@...artitions/code@...000: duplicate unit-address (also used in node /ahb/spi@...30000/flash@...artitions/tfa@...000)
> > It seems odd that the partitions intersect. Are the offsets correct? If
> > they are, can you add comments to the DTS discussing what's going on
> > there?
> I'll delete the code partition. I added it to make it easier for my 
> script to flash both TF-A and UEFI areas at once.

Okay, thanks.

> > 
> > > aspeed-bmc-asrock-altrad8.dtb: gpio@1c (nxp,pca9557): '#address-cells', '#size-cells', 'gpio@0', 'gpio@1', 'gpio@2', 'gpio@3', 'gpio@4', 'gpio@5', 'gpio@6', 'gpio@7' do not match any of the regexes: '^(hog-[0-9]+|.+-hog(-[0-9]+)?)$', '^pinctrl-[0-9]+$'
> > > 	from schema $id: http://devicetree.org/schemas/gpio/gpio-pca95xx.yaml#
> > This one needs fixing.
> 
> I'm confused, because in the existing device tree files I'm only seeing 
> 'hog' used in the &gpio node, while 'pca[0-9]+' is commonly used as the 
> node names for pca95xx devices.

The error above is referring to properties and sub-nodes of your
nxp,pca9557 compatible node, rather than the name of the node itself.
That said, node names are preferred to be generic (e.g. gpio@) rather
than specific.

> 
> Does the gpio-pca95xx.yaml file need to be updated?
> 

It depends on what you're trying to achieve. At v6.17-rc1 no other
devicetree in the kernel defines an nxp,pca9557 node as you have here
with gpio@ subnodes, and neither does the gpio-pca95xx.yaml binding
allow them. What caused you to add them?

I expect what you need to do is remove those sub-nodes, along with
#address-cells and #size-cells.

Andrew