linux-kernel - Re: [PATCH] tracing: dynevent: Add a missing lockdown check on dynevent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20250924232803.c6b1973802b969b86bb7a481@kernel.org>
Date: Wed, 24 Sep 2025 23:28:03 +0900
From: Masami Hiramatsu (Google) <mhiramat@...nel.org>
To: "Masami Hiramatsu (Google)" <mhiramat@...nel.org>
Cc: Steven Rostedt <rostedt@...dmis.org>, Mathieu Desnoyers
 <mathieu.desnoyers@...icios.com>, linux-kernel@...r.kernel.org,
 linux-trace-kernel@...r.kernel.org
Subject: Re: [PATCH] tracing: dynevent: Add a missing lockdown check on
 dynevent

I think this should be backported to stable.

On Fri, 19 Sep 2025 10:15:56 +0900
"Masami Hiramatsu (Google)" <mhiramat@...nel.org> wrote:

> From: Masami Hiramatsu (Google) <mhiramat@...nel.org>
> 
> Since dynamic_events interface on tracefs is compatible with
> kprobe_events and uprobe_events, it should also check the lockdown
> status and reject if it is set.
> 
> Signed-off-by: Masami Hiramatsu (Google) <mhiramat@...nel.org>

Fixes: 17911ff38aa5 ("tracing: Add locked_down checks to the open calls of files created for tracefs")
Cc: stable@...r.kernel.org

Thanks,

> ---
>  kernel/trace/trace_dynevent.c |    4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/kernel/trace/trace_dynevent.c b/kernel/trace/trace_dynevent.c
> index 5d64a18cacac..d06854bd32b3 100644
> --- a/kernel/trace/trace_dynevent.c
> +++ b/kernel/trace/trace_dynevent.c
> @@ -230,6 +230,10 @@ static int dyn_event_open(struct inode *inode, struct file *file)
>  {
>  	int ret;
>  
> +	ret = security_locked_down(LOCKDOWN_TRACEFS);
> +	if (ret)
> +		return ret;
> +
>  	ret = tracing_check_open_get_tr(NULL);
>  	if (ret)
>  		return ret;
> 


-- 
Masami Hiramatsu (Google) <mhiramat@...nel.org>