linux-kernel - Re: [PATCH 0/8] Add OnePlus 6T display (Samsung S6E3FC2X01 DDIC with AMS641RW panel)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7282a888-e550-4d75-838c-0fb242fefdf6@ixit.cz>
Date: Thu, 25 Sep 2025 15:41:34 +0200
From: David Heidelberg <david@...t.cz>
To: Konrad Dybcio <konrad.dybcio@....qualcomm.com>,
 Neil Armstrong <neil.armstrong@...aro.org>,
 Jessica Zhang <jessica.zhang@....qualcomm.com>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
 David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Thierry Reding
 <thierry.reding@...il.com>, Sam Ravnborg <sam@...nborg.org>,
 Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konradybcio@...nel.org>,
 Casey Connolly <casey.connolly@...aro.org>
Cc: dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
 phone-devel@...r.kernel.org
Subject: Re: [PATCH 0/8] Add OnePlus 6T display (Samsung S6E3FC2X01 DDIC with
 AMS641RW panel)

On 25/09/2025 11:37, Konrad Dybcio wrote:
> On 9/25/25 11:12 AM, David Heidelberg via B4 Relay wrote:
>> This patchset enables display on the OnePlus 6T smartphone.
>>
>> Minor adjust to the device-tree of OnePlus 6 had to be done
>> to properly document reset GPIO used. Also same adjustments
>> had been done to the sofef00 panel driver (used by OnePlus 6).
>>
>> In the last step new DDIC driver is introduced together with AMS641RW
>> panel sequences.
> 
> I think you skipped the elephant in the room - some of these patches
> break panel for the phone intermittently..

Thank you for the review Konrad. I plan to incorporate all your 
suggested changes in the next revision.

To clarify, while sofef00 has been introduced as supporting OnePlus 6T 
too, but it never did (and the compatible was removed later).

All the changes CAN'T BREAK anything for OnePlus 6T display as it's not 
supported yet by mainline.

All the changes SHOULDN'T CHANGE anything for the OnePlus 6, as both 
sides (device-tree and the driver) is changed at once to correct reset 
polarity.

David

> 
> Konrad

-- 
David Heidelberg