linux-kernel - Re: [PATCH 0/8] Add OnePlus 6T display (Samsung S6E3FC2X01 DDIC with AMS641RW panel)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <175880949068.820285.11045140052982213642.robh@kernel.org>
Date: Thu, 25 Sep 2025 09:12:34 -0500
From: "Rob Herring (Arm)" <robh@...nel.org>
To: David Heidelberg <david@...t.cz>
Cc: Casey Connolly <casey.connolly@...aro.org>, 
 Sam Ravnborg <sam@...nborg.org>, Simona Vetter <simona@...ll.ch>, 
 devicetree@...r.kernel.org, 
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, 
 linux-arm-msm@...r.kernel.org, phone-devel@...r.kernel.org, 
 Thomas Zimmermann <tzimmermann@...e.de>, 
 Krzysztof Kozlowski <krzk+dt@...nel.org>, 
 Bjorn Andersson <andersson@...nel.org>, Maxime Ripard <mripard@...nel.org>, 
 Jessica Zhang <jessica.zhang@....qualcomm.com>, 
 David Airlie <airlied@...il.com>, Konrad Dybcio <konradybcio@...nel.org>, 
 Thierry Reding <thierry.reding@...il.com>, dri-devel@...ts.freedesktop.org, 
 Conor Dooley <conor+dt@...nel.org>, 
 Neil Armstrong <neil.armstrong@...aro.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/8] Add OnePlus 6T display (Samsung S6E3FC2X01 DDIC
 with AMS641RW panel)


On Thu, 25 Sep 2025 11:12:46 +0200, David Heidelberg wrote:
> This patchset enables display on the OnePlus 6T smartphone.
> 
> Minor adjust to the device-tree of OnePlus 6 had to be done
> to properly document reset GPIO used. Also same adjustments
> had been done to the sofef00 panel driver (used by OnePlus 6).
> 
> In the last step new DDIC driver is introduced together with AMS641RW
> panel sequences.
> 
> Signed-off-by: David Heidelberg <david@...t.cz>
> ---
> Casey Connolly (1):
>       arm64: dts: qcom: sdm845-oneplus: Describe panel vci and poc supplies
> 
> David Heidelberg (7):
>       dt-bindings: panel: Add Samsung S6E3FC2X01 DDIC with panel
>       dt-bindings: display: panel-simple-dsi: Remove Samsung S6E3FC2 compatible
>       arm64: dts: qcom: sdm845-oneplus-fajita: Reflect used panel in compatible
>       arm64: dts: qcom: sdm845-oneplus: Correct panel reset gpio polarity
>       arm64: dts: qcom: sdm845-oneplus: Document TE gpio
>       drm/panel: samsung-sofef00: Invert reset gpio polarity
>       drm/panel: Add Samsung S6E3FC2X01 DDIC with AMS641RW panel
> 
>  .../bindings/display/panel/panel-simple-dsi.yaml   |   2 -
>  .../bindings/display/panel/samsung,s6e3fc2x01.yaml |  77 ++++
>  MAINTAINERS                                        |   6 +
>  .../arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi |  31 +-
>  arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dts |   2 +-
>  drivers/gpu/drm/panel/Kconfig                      |  13 +
>  drivers/gpu/drm/panel/Makefile                     |   1 +
>  drivers/gpu/drm/panel/panel-samsung-s6e3fc2x01.c   | 404 +++++++++++++++++++++
>  drivers/gpu/drm/panel/panel-samsung-sofef00.c      |  10 +-
>  9 files changed, 536 insertions(+), 10 deletions(-)
> ---
> base-commit: ce7f1a983b074f6cf8609068088ca3182c569ee4
> change-id: 20250923-s6e3fc2x01-f9550b822fe5
> 
> Best regards,
> --
> David Heidelberg <david@...t.cz>
> 
> 
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


This patch series was applied (using b4) to base:
 Base: using specified base-commit ce7f1a983b074f6cf8609068088ca3182c569ee4

If this is not the correct base, please add 'base-commit' tag
(or use b4 which does this automatically)

New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/qcom/' for 20250925-s6e3fc2x01-v1-0-9293016768f7@...t.cz:

arch/arm64/boot/dts/qcom/sdm845-oneplus-enchilada.dtb: panel@0 (samsung,sofef00): 'poc-supply', 'te-gpios', 'vci-supply' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/display/panel/panel-simple-dsi.yaml#