linux-kernel - Re: [PATCH 5/8] arm64: dts: qcom: sdm845-oneplus: Correct panel reset gpio polarity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <44229f2c-7004-480f-973b-a36e3288959b@mainlining.org>
Date: Thu, 25 Sep 2025 21:34:44 +0200
From: Jens Reidel <adrian@...nlining.org>
To: david@...t.cz, Neil Armstrong <neil.armstrong@...aro.org>,
 Jessica Zhang <jessica.zhang@....qualcomm.com>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
 David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Thierry Reding
 <thierry.reding@...il.com>, Sam Ravnborg <sam@...nborg.org>,
 Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konradybcio@...nel.org>,
 Casey Connolly <casey.connolly@...aro.org>
Cc: dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
 phone-devel@...r.kernel.org
Subject: Re: [PATCH 5/8] arm64: dts: qcom: sdm845-oneplus: Correct panel reset
 gpio polarity

On 9/25/25 11:12, David Heidelberg via B4 Relay wrote:
> From: David Heidelberg <david@...t.cz>
> 
> Reset GPIO should be active in high state as usually the board doesn't
> invert the polarity.
> 
> Fixes: 288ef8a42612 ("arm64: dts: sdm845: add oneplus6/6t devices")
> Signed-off-by: David Heidelberg <david@...t.cz>
> ---
>   arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
> index aff5e80c1eba43e830991c2afd53b6322893cd27..7f968f90a83b869395bedd5de510ba96de3c4e94 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
> @@ -456,7 +456,7 @@ display_panel: panel@0 {
>   		vci-supply = <&panel_vci_3v3>;
>   		poc-supply = <&panel_vddi_poc_1p8>;
>   
> -		reset-gpios = <&tlmm 6 GPIO_ACTIVE_LOW>;
> +		reset-gpios = <&tlmm 6 GPIO_ACTIVE_HIGH>;
>   
>   		pinctrl-names = "default";
>   		pinctrl-0 = <&panel_reset_pins &panel_te_pin &panel_esd_pin>;
> 

Hi David,

according to the schematics available to me, this GPIO is active low (as 
on most other Qualcomm phones). I'd suggest dropping this and the driver 
change.

Best regards,
Jens